From: Philippe Waroquiers <philippe.waroquiers@skynet.be>
To: Simon Marchi <simark@simark.ca>, gdb-patches@sourceware.org
Subject: Re: [RFA] fix leak in gdb_environ
Date: Sun, 27 Nov 2022 21:16:32 +0100 [thread overview]
Message-ID: <572bb46b3885ec4a0cc66bf687d05a716187a36a.camel@skynet.be> (raw)
In-Reply-To: <dde6f984-8978-75dd-dcc7-994276ec9168@simark.ca>
On Sun, 2022-11-27 at 13:41 -0500, Simon Marchi wrote:
>
> On 11/27/22 13:25, Philippe Waroquiers via Gdb-patches wrote:
> > valgrind reports a leak when assigning a gdb_environ to another gdb_environ.
> > The memory allocated for the target gdb_environ env variables is not released.
> > The gdb_environ selftest reproduces the leak (see below).
> > Fix the leak by clearing the target gbd_environ before std::move-ing the
>
> gbd_environ -> gdb_environ
>
> Otherwise:
>
> Approved-By: Simon Marchi <simon.marchi@efficios.com>
Thanks for the review, pushed with the tag added.
prev parent reply other threads:[~2022-11-27 20:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 18:25 Philippe Waroquiers
2022-11-27 18:41 ` Simon Marchi
2022-11-27 20:16 ` Philippe Waroquiers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=572bb46b3885ec4a0cc66bf687d05a716187a36a.camel@skynet.be \
--to=philippe.waroquiers@skynet.be \
--cc=gdb-patches@sourceware.org \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).