public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Pedro Alves <palves@redhat.com>
To: Phi Debian <phi.debian@gmail.com>
Cc: gdb-patches@sourceware.org
Subject: Re: TUI enhancement suggestion.
Date: Thu, 11 Jun 2020 11:17:26 +0100	[thread overview]
Message-ID: <59ace237-39ff-5d7f-beb0-994ec5e107b8@redhat.com> (raw)
In-Reply-To: <CAJOr74jAJyVx-vzsQTi9P0S_A2yxK=HZ2LjtUG0Ui3LeJX9Tyg@mail.gmail.com>

On 6/10/20 9:25 PM, Phi Debian wrote:
> 
> 
> On Wednesday, June 10, 2020, Pedro Alves <palves@redhat.com <mailto:palves@redhat.com>> wrote:
> 
>     Hi Phi,
> 
>     It would be much better to keep the discussion on the
>     mailing list, so that others could interact as well.
> 
>     Thanks,
>     Pedro Alves
> 
> 
> Ok. Point line in src win along with the nice syntax highlight produce inconsistent background color as Pedro notified in the pics provided. In the example there is a strange yellow background on function names, it seems that the syntax highlight use a BOLD attribute. On basic xterm and vte, this BOLD goes unnoticed. When one use xterm resource colorBD see https://invisible-island.net/xterm/ctlseqs/ctlseqs.html resource also implemented in vte, resource doing the  mapping a color to the BOLD attribute (in the example yellow) it produces this background  color change.
> 
> Dunno if that expected.

I don't know much about these color mappings, but to me it looks like a bug offhand that
requesting "bold" affects the background color.  It would think that "bold" makes the
foreground text... bold.

> 
> I'd like to be able to got more control (config) on how point line is displayed, in my case using underline attribute for point line would be lighter then reverse video line and would preserve (simplify) the syntax highlight. 

If you like it better that way, then maybe others do too.  I don't mind the
new option.

I also wouldn't mind an option to specify a different background color
for the current source line highlight.

> 
> If someones as idea would be interesting to share.
> 
> Cheers,
> Phi 

Thanks,
Pedro Alves


      reply	other threads:[~2020-06-11 10:17 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-09  7:55 Phi Debian
2020-06-09 13:04 ` Pedro Alves
2020-06-09 14:32   ` Phi Debian
2020-06-09 15:03     ` Phi Debian
2020-06-11 10:34       ` Pedro Alves
2020-06-11 13:55         ` Phi Debian
2020-06-15 14:20           ` Pedro Alves
2020-06-15 15:48             ` Hannes Domani
2020-06-15 16:56               ` Phi Debian
2020-06-15 19:30                 ` Pedro Alves
2020-06-15 19:47                   ` Phi Debian
2020-06-15 20:12                   ` Tom Tromey
2020-06-15 20:45                     ` Pedro Alves
2020-06-16  3:38                       ` Phi Debian
2020-06-16 11:02                         ` [PATCH] Add "set style tui-current-position on|off" default to off Pedro Alves
2020-06-16 14:33                           ` Eli Zaretskii
2022-11-15 10:09                           ` Andrew Burgess
2022-11-15 12:15                             ` Pedro Alves
2022-11-16 10:41                               ` Andrew Burgess
2022-11-17  6:30                                 ` Phi Debian
     [not found]   ` <CAJOr74jg==A7NM4qtWEq6neXqxpxxtUEVdDgsahfvRobW+Q0wA@mail.gmail.com>
     [not found]     ` <CAJOr74hQdi6Y4MpGy=J-3CTRA2PP08OebTO2hBFN5NyDRokb3Q@mail.gmail.com>
     [not found]       ` <CAJOr74gyyw4hJm9j0fzKQdzkJKzq=yiAXyZx_c2Q=RA8GTSN7Q@mail.gmail.com>
     [not found]         ` <ed9ea9c6-3d4d-6ba7-4672-bff2b2617012@redhat.com>
2020-06-10 20:25           ` TUI enhancement suggestion Phi Debian
2020-06-11 10:17             ` Pedro Alves [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=59ace237-39ff-5d7f-beb0-994ec5e107b8@redhat.com \
    --to=palves@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=phi.debian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).