From: Andrew Burgess <aburgess@redhat.com>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Cc: Phi Debian <phi.debian@gmail.com>
Subject: Re: [PATCH] Add "set style tui-current-position on|off" default to off
Date: Wed, 16 Nov 2022 10:41:37 +0000 [thread overview]
Message-ID: <87zgcr89lq.fsf@redhat.com> (raw)
In-Reply-To: <adfa716c-adcc-d43e-58eb-81d49349df9a@palves.net>
Pedro Alves <pedro@palves.net> writes:
> On 2022-11-15 10:09 a.m., Andrew Burgess wrote:
>
>> I'd be interested to see this patch merged. I took a look through the
>> code changes, and it all looks good to me.
>>
>> Attached below is a rebase of Pedro's patch. I've gone through the docs
>> and comments to mention assembly highlighting, which has been added to
>> GDB since this patch was originally written.
>>
>> I've left the author email as 'Pedro Alves <palves@redhat.com>' as this
>> reflects where/when the patch was written, but I can update this to
>> anything more suitable upon request.
>>
>> Pedro (or anyone) - any objections if I merge this patch?
>
> LGTM. Thanks for pushing this forward.
Thanks. I've pushed the patch.
Andrew
next prev parent reply other threads:[~2022-11-16 10:41 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-09 7:55 TUI enhancement suggestion Phi Debian
2020-06-09 13:04 ` Pedro Alves
2020-06-09 14:32 ` Phi Debian
2020-06-09 15:03 ` Phi Debian
2020-06-11 10:34 ` Pedro Alves
2020-06-11 13:55 ` Phi Debian
2020-06-15 14:20 ` Pedro Alves
2020-06-15 15:48 ` Hannes Domani
2020-06-15 16:56 ` Phi Debian
2020-06-15 19:30 ` Pedro Alves
2020-06-15 19:47 ` Phi Debian
2020-06-15 20:12 ` Tom Tromey
2020-06-15 20:45 ` Pedro Alves
2020-06-16 3:38 ` Phi Debian
2020-06-16 11:02 ` [PATCH] Add "set style tui-current-position on|off" default to off Pedro Alves
2020-06-16 14:33 ` Eli Zaretskii
2022-11-15 10:09 ` Andrew Burgess
2022-11-15 12:15 ` Pedro Alves
2022-11-16 10:41 ` Andrew Burgess [this message]
2022-11-17 6:30 ` Phi Debian
[not found] ` <CAJOr74jg==A7NM4qtWEq6neXqxpxxtUEVdDgsahfvRobW+Q0wA@mail.gmail.com>
[not found] ` <CAJOr74hQdi6Y4MpGy=J-3CTRA2PP08OebTO2hBFN5NyDRokb3Q@mail.gmail.com>
[not found] ` <CAJOr74gyyw4hJm9j0fzKQdzkJKzq=yiAXyZx_c2Q=RA8GTSN7Q@mail.gmail.com>
[not found] ` <ed9ea9c6-3d4d-6ba7-4672-bff2b2617012@redhat.com>
2020-06-10 20:25 ` TUI enhancement suggestion Phi Debian
2020-06-11 10:17 ` Pedro Alves
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgcr89lq.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=pedro@palves.net \
--cc=phi.debian@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).