Re: [PATCH v2] gdb: Fix issue with Clang CLI macros

[Simon Marchi <simark@simark.ca>]

On 2022-10-17 10:54, Bruno Larsen wrote:
> Hi Simon,
> 
> thanks for the review. I've fixed everything else you mentioned, but:
> 
> On 17/10/2022 14:32, Simon Marchi wrote:
>>> +#https://github.com/llvm/llvm-project/issues/54506
>>> +
>>> +load_lib dwarf.exp
>>> +
>>> +if {![dwarf2_support]} {
>>> +    return 0
>>> +}
>>> +if {![test_compiler_info gcc-*-*]} {
>>> +    untested "dwarf assembler needs GCC"
>>> +}
>>> +
>>> +standard_testfile .S
>>> +
>>> +set srcfile macro-source-path.c
>> copy-pasto.  Actually, can you use:
>>
>>    standard_testfile .c .S
>>
>> and then use $srcfile for the .c, and $srcfile2 (which you can reassign
>> to $asm_file for clarity) for the .S?
>>
> This isn't actually a copy-pasto problem. I am using macro-source-path.c because I only need a .c file with a main function and the label, so I decided to go with a file that was already there. Do you think I should have a .c file anyway, or should I just document this for v3?

I prefer not to share test files randomly between tests, for
consistency, clarity, and so there aren't surprises when you modify a
test.

Simon