Re: [PATCH v2] gdb: Fix issue with Clang CLI macros

[Simon Marchi <simark@simark.ca>]

On 2022-10-17 06:26, Bruno Larsen via Gdb-patches wrote:
> Clang up to the current version adds macros that were defined in the
> command line or by "other means", according to the Dwarf specification,
> after the last DW_MACRO_end_file, instead of before the first
> DW_MACRO_start_file, as the specification dictates.  When GDB reads the
> macros after the last file is closed, the macros never end up "in scope"
> and so we can't print them.  This has been submitted as a bug to Clang
> developers, and PR macros/29034 was opened for GDB to keep track of
> this.
> 
> Seeing as there is no expected date for it to be fixed, a workaround was
> added for all current versions of Clang.  The workaround detects when
> the main file would be closed and if the producer is clang, and turns
> that operation into a noop, so we keep a reference to the current_file
> as those macros are read.
> 
> A test case was added to confirm the functionality.
> 
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29034

I forgot to mention, should this setup_kfail be removed?

https://gitlab.com/gnutools/binutils-gdb/-/blob/e57f7fa070e16683c0e1ddd0d1307d243fad990d/gdb/testsuite/gdb.base/macro-source-path.exp#L68

Simon