Re: [PATCHv2] gdb/python: Add gdb.InferiorThread.details attribute

[Simon Marchi <simon.marchi@polymtl.ca>]

On 2022-02-28 06:30, Andrew Burgess via Gdb-patches wrote:
> * Tom Tromey <tom@tromey.com> [2022-02-25 12:33:42 -0700]:
> 
>>>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:
>>
>> Andrew> As the string returned by target_extra_thread_info is unstructured,
>> Andrew> this attribute is only really useful for echoing straight through to
>> Andrew> the user, but, if a user wants to write a command that displays the
>> Andrew> same, or a similar 'Thread Id' to the one seen in 'info threads', then
>> Andrew> they need access to this string.
>>
>> It may be good to give a bit more information about this in the
>> documentation.  Like, describing what this is used for and maybe how it
>> would appear on a Linux system.
>>
>> Andrew> +  const char *extra_info = target_extra_thread_info (thread_obj->thread);
>>
>> If this can ever throw, it will break things here.
> 
> Thanks for the feedback.  In v2:
> 
>   - Improved the docs to given an example of what the string might
>     contain, and where GDB currently displays the string, and
> 
>   - Use try/catch and GDB_PY_HANDLE_EXCEPTION in py-infthread.c in
>     to handle any exceptions thrown from GDB core.
> 
> Thanks,
> Andrew
> 
> ---
> 
> gdb/python: Add gdb.InferiorThread.details attribute
> 
> This adds a new read-only attribute gdb.InferiorThread.details, this
> attribute contains a string, the results of target_extra_thread_info
> for the thread, or None, if target_extra_thread_info returns nullptr.
> 
> As the string returned by target_extra_thread_info is unstructured,
> this attribute is only really useful for echoing straight through to
> the user, but, if a user wants to write a command that displays the
> same, or a similar 'Thread Id' to the one seen in 'info threads', then
> they need access to this string.
> 
> Given that the string produced by target_extra_thread_info varies by
> target, there's only minimal testing of this attribute, I check that
> the attribute can be accessed, and that the return value is either
> None, or a string.

This LGTM, thanks.

Simon