public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org>
Cc: Andrew Burgess <aburgess@redhat.com>
Subject: Re: [PATCH] gdb/python: Add gdb.InferiorThread.details attribute
Date: Fri, 25 Feb 2022 12:33:42 -0700	[thread overview]
Message-ID: <87fso6n3l5.fsf@tromey.com> (raw)
In-Reply-To: <20220215115233.56924-1-aburgess@redhat.com> (Andrew Burgess via Gdb-patches's message of "Tue, 15 Feb 2022 11:52:33 +0000")

>>>>> "Andrew" == Andrew Burgess via Gdb-patches <gdb-patches@sourceware.org> writes:

Andrew> As the string returned by target_extra_thread_info is unstructured,
Andrew> this attribute is only really useful for echoing straight through to
Andrew> the user, but, if a user wants to write a command that displays the
Andrew> same, or a similar 'Thread Id' to the one seen in 'info threads', then
Andrew> they need access to this string.

It may be good to give a bit more information about this in the
documentation.  Like, describing what this is used for and maybe how it
would appear on a Linux system.

Andrew> +  const char *extra_info = target_extra_thread_info (thread_obj->thread);

If this can ever throw, it will break things here.

Tom

  reply	other threads:[~2022-02-25 19:33 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-02-15 11:52 Andrew Burgess
2022-02-25 19:33 ` Tom Tromey [this message]
2022-02-28 11:30   ` [PATCHv2] " Andrew Burgess
2022-02-28 12:39     ` Eli Zaretskii
2022-02-28 14:52     ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87fso6n3l5.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).