public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 1/2] [gdb/testsuite] Simplify gdb.server/server-kill-python.exp
Date: Wed, 17 Apr 2024 11:48:46 +0200	[thread overview]
Message-ID: <5ee0788d-44e2-456b-a691-7dbe6e82a8a2@suse.de> (raw)
In-Reply-To: <87il0h1awx.fsf@tromey.com>

On 4/16/24 19:21, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom>  # Now start GDB, sourcing the python command file we generated above.
> Tom>  # Set the height and width so we don't end up at a paging prompt.
> Tom>  if {[gdb_spawn_with_cmdline_opts \
> Tom> -	 "-quiet -iex \"set height 0\" -iex \"set width 0\" -ex \"source $host_file1\""] != 0} {
> Tom> +	 "-quiet -iex \"set height 0\" -iex \"set width 0\""] != 0} {
> Tom>      fail "spawn"
> Tom>      return
> 
> Do this even need any arguments now?  I thought the default was to set
> width and height to 0.

Indeed that's not needed.

I've committed this in the current, "minimal change" form, and I'll 
write a patch cleaning up the issue you raised here in general.

Thanks,
- Tom

      reply	other threads:[~2024-04-17  9:48 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-04-12 17:51 Tom de Vries
2024-04-12 17:51 ` [PATCH 2/2] [gdb/testsuite] Fix gdbserver pid in gdb.server/server-kill-python.exp Tom de Vries
2024-04-16 17:21 ` [PATCH 1/2] [gdb/testsuite] Simplify gdb.server/server-kill-python.exp Tom Tromey
2024-04-17  9:48   ` Tom de Vries [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5ee0788d-44e2-456b-a691-7dbe6e82a8a2@suse.de \
    --to=tdevries@suse.de \
    --cc=gdb-patches@sourceware.org \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).