* [PATCH] gdb/testsuite/rocm: fix rocm-multi-inferior-gpu.cpp
@ 2023-09-11 15:04 Lancelot Six
2023-09-11 17:52 ` Tom Tromey
0 siblings, 1 reply; 3+ messages in thread
From: Lancelot Six @ 2023-09-11 15:04 UTC (permalink / raw)
To: gdb-patches; +Cc: lsix, Lancelot Six
The gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp testcase contains a
call to execl which does not have NULL as a last argument. This is
an invalid use of execl. This patch fixes this oversight.
Change-Id: I03b60abe30468d71ba5089b240c6d00f9b8883b2
---
gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp
index ca869233b58..d64afdd1994 100644
--- a/gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp
+++ b/gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp
@@ -62,7 +62,7 @@ parent (int argc, char **argv)
if (pid == 0)
{
/* Exec to force the child to re-initialize the ROCm runtime. */
- if (execl (argv[0], argv[0], n) == -1)
+ if (execl (argv[0], argv[0], n, nullptr) == -1)
{
perror ("Failed to exec");
return -1;
base-commit: cdda72c2fa1e47c566c7b5768f3831a1cc11d263
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb/testsuite/rocm: fix rocm-multi-inferior-gpu.cpp
2023-09-11 15:04 [PATCH] gdb/testsuite/rocm: fix rocm-multi-inferior-gpu.cpp Lancelot Six
@ 2023-09-11 17:52 ` Tom Tromey
2023-09-12 8:18 ` Lancelot SIX
0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2023-09-11 17:52 UTC (permalink / raw)
To: Lancelot Six via Gdb-patches; +Cc: Lancelot Six, lsix
>>>>> "Lancelot" == Lancelot Six via Gdb-patches <gdb-patches@sourceware.org> writes:
Lancelot> The gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp testcase contains a
Lancelot> call to execl which does not have NULL as a last argument. This is
Lancelot> an invalid use of execl. This patch fixes this oversight.
Thank you. FAOD and for future reference, I think it could have gone in
by the obvious rule.
Approved-By: Tom Tromey <tom@tromey.com>
Tom
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] gdb/testsuite/rocm: fix rocm-multi-inferior-gpu.cpp
2023-09-11 17:52 ` Tom Tromey
@ 2023-09-12 8:18 ` Lancelot SIX
0 siblings, 0 replies; 3+ messages in thread
From: Lancelot SIX @ 2023-09-12 8:18 UTC (permalink / raw)
To: Tom Tromey, Lancelot Six via Gdb-patches; +Cc: lsix
On 11/09/2023 18:52, Tom Tromey wrote:
>>>>>> "Lancelot" == Lancelot Six via Gdb-patches <gdb-patches@sourceware.org> writes:
>
> Lancelot> The gdb/testsuite/gdb.rocm/multi-inferior-gpu.cpp testcase contains a
> Lancelot> call to execl which does not have NULL as a last argument. This is
> Lancelot> an invalid use of execl. This patch fixes this oversight.
>
> Thank you. FAOD and for future reference, I think it could have gone in
> by the obvious rule.
>
> Approved-By: Tom Tromey <tom@tromey.com>
>
> Tom
Thanks,
I have just pushed this patch.
I did wonder if I should use the obv rule for this, but ended up not
using it. I'll keep that in mind for future patches!
Best,
Lancelot.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-09-12 8:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-09-11 15:04 [PATCH] gdb/testsuite/rocm: fix rocm-multi-inferior-gpu.cpp Lancelot Six
2023-09-11 17:52 ` Tom Tromey
2023-09-12 8:18 ` Lancelot SIX
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).