public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom de Vries <tdevries@suse.de>
To: "Kempke, Nils-Christian" <nils-christian.kempke@intel.com>,
	Andrew Burgess <aburgess@redhat.com>,
	"gdb-patches@sourceware.org" <gdb-patches@sourceware.org>
Cc: "JiniSusan.George@amd.com" <JiniSusan.George@amd.com>
Subject: Re: [PATCH v2 12/16] testsuite, fortran: fix info-types for intel compilers
Date: Fri, 3 Jun 2022 08:53:40 +0200	[thread overview]
Message-ID: <617cf9fe-9aee-43e9-9241-cd813fda8ed7@suse.de> (raw)
In-Reply-To: <CY4PR1101MB20715B3AF61839664FB5D72EB8DF9@CY4PR1101MB2071.namprd11.prod.outlook.com>

On 6/1/22 11:21, Kempke, Nils-Christian wrote:
> 
> 
>> -----Original Message-----
>> From: Tom de Vries <tdevries@suse.de>
>> Sent: Wednesday, June 1, 2022 7:25 AM
>> To: Andrew Burgess <aburgess@redhat.com>; Kempke, Nils-Christian <nils-
>> christian.kempke@intel.com>; gdb-patches@sourceware.org
>> Cc: JiniSusan.George@amd.com
>> Subject: Re: [PATCH v2 12/16] testsuite, fortran: fix info-types for intel
>> compilers
>>
>> On 5/31/22 18:06, Andrew Burgess via Gdb-patches wrote:
>>> Nils-Christian Kempke <nils-christian.kempke@intel.com> writes:
>>>
>>>> This info-types.exp test case had a few issues that this patch fixes.
>>>>
>>
>> I'm seeing this regression:
>> ...
>> Running
>> /home/vries/gdb_versions/devel/src/gdb/testsuite/gdb.fortran/info-
>> types.exp
>> ...
>> gdb compile failed,
>> /home/vries/gdb_versions/devel/src/gdb/testsuite/gdb.fortran/info-
>> types.f90:47:13:
>>
>>      type (m1t1) :: var_b
>>                1
>> Error: Derived type 'm1t1' at (1) is being used before it is defined
>> /home/vries/gdb_versions/devel/src/gdb/testsuite/gdb.fortran/info-
>> types.f90:50:8:
>>
>>      var_b%b = 2
>>           1
>> Error: Symbol 'var_b' at (1) has no IMPLICIT type
>> UNTESTED: gdb.fortran/info-types.exp: failed to prepare
>> ...
>>
>> Likewise for a few other test-cases that use the same source.
>>
>> Thanks,
>> - Tom
> 
> Hi Tom,
> 
> Sorry for this, too. I did not change the executable - nor the actual
> compilation of it I think but this must be the source of the regressions.
> 
> I made one of the checks in the info-types.exp file optional, but that does
> not really explain the problems you are seeing..
> 
> I cannot reproduce this currently. I assume this is from a native run? Does
> this also happen in the tests when ran individually? Or is this failure related
> to the regressions seen because of the compiler_info caching?
> 

Hi Nils,

I've not been able to reproduce this anymore.

I'm gonna assume that this was due to an incorrect temporary fix I was 
trying out.

I currently just have a patch in my master-local branch that disables 
compiler_info caching, and that seems to work fine.

Sorry for the noise.

Thanks,
- Tom

  reply	other threads:[~2022-06-03  6:53 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-31  9:24 [PATCH v2 00/16] Fortran compiler identification and ifx testsuite support Nils-Christian Kempke
2022-05-31  9:24 ` [PATCH v2 03/16] gdb/testsuite: Fix fortran types for Intel compilers Nils-Christian Kempke
2022-05-31 14:15   ` Andrew Burgess
2022-05-31 14:48     ` Kempke, Nils-Christian
2022-05-31  9:24 ` [PATCH v2 04/16] gdb/testsuite: move getting_compiler_info to front of gdb_compile Nils-Christian Kempke
2022-05-31 16:00   ` Andrew Burgess
2022-05-31  9:24 ` [PATCH v2 06/16] gdb/testsuite: rename intel next gen c/cpp compilers Nils-Christian Kempke
2022-05-31 14:47   ` Andrew Burgess
2022-05-31  9:24 ` [PATCH v2 10/16] testsuite, fortran: Add '-debug-parameters all' when using ifx/ifort Nils-Christian Kempke
2022-05-31 16:03   ` Andrew Burgess
2022-05-31  9:24 ` [PATCH v2 12/16] testsuite, fortran: fix info-types for intel compilers Nils-Christian Kempke
2022-05-31 16:06   ` Andrew Burgess
2022-06-01  5:25     ` Tom de Vries
2022-06-01  9:21       ` Kempke, Nils-Christian
2022-06-03  6:53         ` Tom de Vries [this message]
2022-05-31  9:24 ` [PATCH v2 16/16] gdb/testsuite: fixup common-block.exp " Nils-Christian Kempke
2022-05-31 16:08   ` Andrew Burgess
2022-05-31 16:14 ` [PATCH v2 00/16] Fortran compiler identification and ifx testsuite support Andrew Burgess
2022-05-31 16:27   ` Kempke, Nils-Christian
2022-05-31 19:33   ` Tom de Vries
2022-06-01  4:54     ` Tom de Vries
2022-06-01  5:13       ` Tom de Vries
2022-06-01  6:44         ` Kempke, Nils-Christian
2022-06-01  7:10           ` Kempke, Nils-Christian
2022-06-01  7:32             ` Tom de Vries
2022-06-01  9:23               ` Kempke, Nils-Christian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=617cf9fe-9aee-43e9-9241-cd813fda8ed7@suse.de \
    --to=tdevries@suse.de \
    --cc=JiniSusan.George@amd.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=nils-christian.kempke@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).