From: Andrew Burgess <aburgess@redhat.com>
To: Nils-Christian Kempke <nils-christian.kempke@intel.com>,
gdb-patches@sourceware.org
Cc: JiniSusan.George@amd.com
Subject: Re: [PATCH v2 10/16] testsuite, fortran: Add '-debug-parameters all' when using ifx/ifort
Date: Tue, 31 May 2022 17:03:25 +0100 [thread overview]
Message-ID: <87r149d702.fsf@redhat.com> (raw)
In-Reply-To: <20220531092423.2361679-5-nils-christian.kempke@intel.com>
Nils-Christian Kempke via Gdb-patches <gdb-patches@sourceware.org>
writes:
> In order for ifx and ifort to emit all debug entries, even for unused
> parameters in modules we have to define the '-debug-parameters all' flag.
>
> This commit adds it to the ifx-*/ifort-* specific flags in gdb.exp.
LGTM.
Thanks,
Andrew
> ---
> gdb/testsuite/lib/gdb.exp | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
> index 87f0a36fe7..402450152a 100644
> --- a/gdb/testsuite/lib/gdb.exp
> +++ b/gdb/testsuite/lib/gdb.exp
> @@ -4473,6 +4473,8 @@ proc gdb_compile {source dest type options} {
> # Place (and look for) Fortran `.mod` files in the output
> # directory for this specific test. For Intel compilers the -J
> # option is not supported so instead use the -module flag.
> + # Additionally, Intel compilers need the -debug-parameters flag set to
> + # emit debug info for all parameters in modules.
> if { !$getting_compiler_info && [lsearch -exact $options f90] != -1 } {
> # Fortran compile.
> set mod_path [standard_output_file ""]
> @@ -4481,6 +4483,7 @@ proc gdb_compile {source dest type options} {
> } elseif { [test_compiler_info {ifort-*} f90]
> || [test_compiler_info {ifx-*} f90] } {
> lappend new_options "additional_flags=-module ${mod_path}"
> + lappend new_options "additional_flags=-debug-parameters all"
> }
> }
>
> --
> 2.25.1
>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928
next prev parent reply other threads:[~2022-05-31 16:04 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-31 9:24 [PATCH v2 00/16] Fortran compiler identification and ifx testsuite support Nils-Christian Kempke
2022-05-31 9:24 ` [PATCH v2 03/16] gdb/testsuite: Fix fortran types for Intel compilers Nils-Christian Kempke
2022-05-31 14:15 ` Andrew Burgess
2022-05-31 14:48 ` Kempke, Nils-Christian
2022-05-31 9:24 ` [PATCH v2 04/16] gdb/testsuite: move getting_compiler_info to front of gdb_compile Nils-Christian Kempke
2022-05-31 16:00 ` Andrew Burgess
2022-05-31 9:24 ` [PATCH v2 06/16] gdb/testsuite: rename intel next gen c/cpp compilers Nils-Christian Kempke
2022-05-31 14:47 ` Andrew Burgess
2022-05-31 9:24 ` [PATCH v2 10/16] testsuite, fortran: Add '-debug-parameters all' when using ifx/ifort Nils-Christian Kempke
2022-05-31 16:03 ` Andrew Burgess [this message]
2022-05-31 9:24 ` [PATCH v2 12/16] testsuite, fortran: fix info-types for intel compilers Nils-Christian Kempke
2022-05-31 16:06 ` Andrew Burgess
2022-06-01 5:25 ` Tom de Vries
2022-06-01 9:21 ` Kempke, Nils-Christian
2022-06-03 6:53 ` Tom de Vries
2022-05-31 9:24 ` [PATCH v2 16/16] gdb/testsuite: fixup common-block.exp " Nils-Christian Kempke
2022-05-31 16:08 ` Andrew Burgess
2022-05-31 16:14 ` [PATCH v2 00/16] Fortran compiler identification and ifx testsuite support Andrew Burgess
2022-05-31 16:27 ` Kempke, Nils-Christian
2022-05-31 19:33 ` Tom de Vries
2022-06-01 4:54 ` Tom de Vries
2022-06-01 5:13 ` Tom de Vries
2022-06-01 6:44 ` Kempke, Nils-Christian
2022-06-01 7:10 ` Kempke, Nils-Christian
2022-06-01 7:32 ` Tom de Vries
2022-06-01 9:23 ` Kempke, Nils-Christian
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87r149d702.fsf@redhat.com \
--to=aburgess@redhat.com \
--cc=JiniSusan.George@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=nils-christian.kempke@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).