From: Carl Love <cel@us.ibm.com>
To: Simon Marchi <simark@simark.ca>,
blarsen@redhat.com, gdb-patches@sourceware.org,
UlrichWeigand <Ulrich.Weigand@de.ibm.com>,
pedro@palves.net
Cc: luis.machado@arm.com
Subject: [PATCH 1/2] Add gdb_compile options column-info and no-column-info
Date: Fri, 25 Aug 2023 08:53:50 -0700 [thread overview]
Message-ID: <6236dcd25a41dbc3ef970206383360aafa3321dd.camel@us.ibm.com> (raw)
In-Reply-To: <6d10baef346804f88821dd36cd8ab1aac3bf210a.camel@us.ibm.com>
Simon, GDB maintainers:
Version 2, updated the compiler check and handling for gcc version 6
and earlier. Retested on Power 10.
Per the comments on version 4 for the gdb.reverse/func-map-to-same-
line.exp, I have added support to proc gdb_compile to enable or disable
generating line information as part of the debug information. The two
new options are column-info and no-column-info.
This patch implements the new options for gdb_compile.
These options have been tested with patch 2 of 2 on PowerPC with the
GCC and clang compilers.
Please let me know if the patch is acceptable for mainline. Thanks.
Carl
------------------------------------------------------
Add gdb_compile options column-info and no-column-info
This patch adds two new options to gdb_compile to specify if the compile
should or should not generate the line table information. The
options are supported on clang and gcc version 7 and newer.
Patch has been tested on PowerPC with both gcc and clang.
---
gdb/testsuite/lib/gdb.exp | 34 ++++++++++++++++++++++++++++++++++
1 file changed, 34 insertions(+)
diff --git a/gdb/testsuite/lib/gdb.exp b/gdb/testsuite/lib/gdb.exp
index 8432e636ecc..e321e4e5ecc 100644
--- a/gdb/testsuite/lib/gdb.exp
+++ b/gdb/testsuite/lib/gdb.exp
@@ -4896,6 +4896,8 @@ proc quote_for_host { args } {
# debug information
# - text_segment=addr: Tell the linker to place the text segment at ADDR.
# - build-id: Ensure the final binary includes a build-id.
+# - no-column-info: Disable generation of column table information.
+# - column-info: Enable generation of column table information.
#
# And here are some of the not too obscure options understood by DejaGnu that
# influence the compilation:
@@ -5105,6 +5107,38 @@ proc gdb_compile {source dest type options} {
} else {
error "Don't know how to handle text_segment option."
}
+ } elseif { $opt == "column-info" } {
+ # If GCC or clang does not support column-info, compilation
+ # will fail and the usupported column-info option will be
+ # reported as such.
+ if {[test_compiler_info {gcc-*}]} {
+ lappend new_options "additional_flags=-gcolumn-info"
+
+ } elseif {[test_compiler_info {clang-*}]} {
+ lappend new_options "additional_flags=-gcolumn-info"
+
+ } else {
+ error "Don't know how to handle gcolumn-info option."
+ }
+
+ } elseif { $opt == "no-column-info" } {
+ if {[test_compiler_info {gcc-*}]} {
+ if {[test_compiler_info {gcc-[1-6]-*}]} {
+ # In this case, don't add the compile line option and
+ # the result will be the same as using no-column-info
+ # on a version that supports the option.
+ warning "gdb_compile option no-column-info not supported, ignoring."
+ } else {
+ lappend new_options "additional_flags=-gno-column-info"
+ }
+
+ } elseif {[test_compiler_info {clang-*}]} {
+ lappend new_options "additional_flags=-gno-column-info"
+
+ } else {
+ error "Don't know how to handle gno-column-info option."
+ }
+
} else {
lappend new_options $opt
}
--
2.37.2
next prev parent reply other threads:[~2023-08-25 15:53 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 15:50 [PATCH 0/2] Fix reverse stepping multiple contiguous PC ranges over the line table Carl Love
2023-08-25 15:53 ` Carl Love [this message]
2023-08-25 15:57 ` [PATCH 2/2 ver 8] " Carl Love
2023-08-29 12:28 ` [PATCH 0/2] " Guinevere Larsen
2023-08-29 18:55 ` Carl Love
2023-09-05 15:12 ` Carl Love
2023-09-25 22:15 ` Carl Love
2023-11-02 17:30 ` PING " Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6236dcd25a41dbc3ef970206383360aafa3321dd.camel@us.ibm.com \
--to=cel@us.ibm.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=pedro@palves.net \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).