From: Guinevere Larsen <blarsen@redhat.com>
To: Carl Love <cel@us.ibm.com>, Simon Marchi <simark@simark.ca>,
gdb-patches@sourceware.org,
UlrichWeigand <Ulrich.Weigand@de.ibm.com>,
pedro@palves.net
Cc: luis.machado@arm.com
Subject: Re: [PATCH 0/2] Fix reverse stepping multiple contiguous PC ranges over the line table.
Date: Tue, 29 Aug 2023 14:28:53 +0200 [thread overview]
Message-ID: <28ab7382-a91a-1ed1-de18-c695ae3669d4@redhat.com> (raw)
In-Reply-To: <6d10baef346804f88821dd36cd8ab1aac3bf210a.camel@us.ibm.com>
On 25/08/2023 17:50, Carl Love wrote:
> GDB maintainers:
>
> I received a few messages from Guinevere about these two patches. In
> the end, we agreed the first patch was OK. There was a minor code
> change suggested for the second patch that I have implemented. Since I
> have not received any additional suggestions on the second patch, it is
> time to ping the first patch and post the updated second patch for
> review.
>
> The first patch in the series has not been changed. I am reposting it
> along with the second patch so it doesn't get lost.
>
> The patch series has been tested on Power10 LE and on X86-64.
>
> Please let me know if these two patches are acceptable for mainline.
> Thanks.
>
> Carl
>
I have tested this patch with both GCC and Clang. I can verify it fixes
the issue, adds no regression, and even fixes the final issues when
testing gdb.reverse with clang!
Tested-By: Guinevere Larsen <blarsen@redhat.com>
--
Cheers,
Guinevere Larsen
She/Her/Hers
next prev parent reply other threads:[~2023-08-29 12:28 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-25 15:50 Carl Love
2023-08-25 15:53 ` [PATCH 1/2] Add gdb_compile options column-info and no-column-info Carl Love
2023-08-25 15:57 ` [PATCH 2/2 ver 8] Fix reverse stepping multiple contiguous PC ranges over the line table Carl Love
2023-08-29 12:28 ` Guinevere Larsen [this message]
2023-08-29 18:55 ` [PATCH 0/2] " Carl Love
2023-09-05 15:12 ` Carl Love
2023-09-25 22:15 ` Carl Love
2023-11-02 17:30 ` PING " Carl Love
-- strict thread matches above, loose matches on Subject: below --
2023-08-07 18:54 Carl Love
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=28ab7382-a91a-1ed1-de18-c695ae3669d4@redhat.com \
--to=blarsen@redhat.com \
--cc=Ulrich.Weigand@de.ibm.com \
--cc=cel@us.ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=luis.machado@arm.com \
--cc=pedro@palves.net \
--cc=simark@simark.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).