From: Simon Marchi <simark@simark.ca>
To: Simon Marchi <simon.marchi@polymtl.ca>, gdb-patches@sourceware.org
Cc: Simon Marchi <simon.marchi@efficios.com>
Subject: Re: [PATCH v2 1/3] gdbsupport: move include/gdb/fileio.h contents to fileio.h
Date: Wed, 21 Sep 2022 14:13:32 -0400 [thread overview]
Message-ID: <623a8aa1-e617-12f4-3fc3-70924eca1cde@simark.ca> (raw)
In-Reply-To: <20220829162926.3752040-2-simon.marchi@polymtl.ca>
On 2022-08-29 12:29, Simon Marchi via Gdb-patches wrote:
> From: Simon Marchi <simon.marchi@efficios.com>
>
> I don't see why include/gdb/fileio.h is placed there. It's not
> installed by "make install", and it's not included by anything outside
> of gdb/gdbserver/gdbsupport.
>
> Move its content back to gdbsupport/fileio.h. I have omitted the bits
> inside an `#if 0`, since it's obviously not used, as well as the
> "limits" constants, which are also unused.
>
> Change-Id: I6fbc2ea10fbe4cfcf15f9f76006b31b99c20e5a9
I pushed this series.
Simon
next prev parent reply other threads:[~2022-09-21 18:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-08-26 19:54 [PATCH " Simon Marchi
2022-08-26 19:54 ` [PATCH 2/3] gdbsupport: convert FILEIO_* macros to an enum Simon Marchi
2022-08-26 19:54 ` [PATCH 3/3] gdbsupport: move fileio_errno_to_host to fileio.{h.cc} and rename Simon Marchi
2022-08-29 16:29 ` [PATCH v2 0/3] fileio error cleanups Simon Marchi
2022-08-29 16:29 ` [PATCH v2 1/3] gdbsupport: move include/gdb/fileio.h contents to fileio.h Simon Marchi
2022-09-21 18:13 ` Simon Marchi [this message]
2022-08-29 16:29 ` [PATCH v2 2/3] gdbsupport: convert FILEIO_* macros to an enum Simon Marchi
2022-08-29 16:29 ` [PATCH v2 3/3] gdbsupport: move fileio_errno_to_host to fileio.{h, cc} and rename Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=623a8aa1-e617-12f4-3fc3-70924eca1cde@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
--cc=simon.marchi@polymtl.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).