From: Simon Marchi <simark@simark.ca>
To: John Baldwin <jhb@FreeBSD.org>, gdb-patches@sourceware.org
Subject: Re: [PATCH] aarch64: Use aarch64_debug_printf in a few more places
Date: Tue, 27 Feb 2024 23:38:49 -0500 [thread overview]
Message-ID: <624e7ed2-efc8-44c0-b6d8-d0fc67af7e6f@simark.ca> (raw)
In-Reply-To: <20240227222043.10218-1-jhb@FreeBSD.org>
On 2024-02-27 17:20, John Baldwin wrote:
> No functional change
> ---
> gdb/arch/aarch64-insn.c | 51 +++++++++++++++--------------------------
> 1 file changed, 19 insertions(+), 32 deletions(-)
>
> diff --git a/gdb/arch/aarch64-insn.c b/gdb/arch/aarch64-insn.c
> index 10818757cd4..3e40a51c443 100644
> --- a/gdb/arch/aarch64-insn.c
> +++ b/gdb/arch/aarch64-insn.c
> @@ -98,13 +98,10 @@ aarch64_decode_b (CORE_ADDR addr, uint32_t insn, int *is_bl,
> *is_bl = (insn >> 31) & 0x1;
> *offset = sbits (insn, 0, 25) * 4;
>
> - if (aarch64_debug)
> - {
> - debug_printf ("decode: 0x%s 0x%x %s 0x%s\n",
> - core_addr_to_string_nz (addr), insn,
> - *is_bl ? "bl" : "b",
> - core_addr_to_string_nz (addr + *offset));
> - }
> + aarch64_debug_printf ("decode: 0x%s 0x%x %s 0x%s\n",
> + core_addr_to_string_nz (addr), insn,
> + *is_bl ? "bl" : "b",
> + core_addr_to_string_nz (addr + *offset));
You should remove the \n, I think, the _debug_printf functions adds one.
Otherwise, LGTM.
Approved-By: Simon Marchi <simon.marchi@efficios.com>
Simon
prev parent reply other threads:[~2024-02-28 4:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-27 22:20 John Baldwin
2024-02-28 4:38 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=624e7ed2-efc8-44c0-b6d8-d0fc67af7e6f@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=jhb@FreeBSD.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).