public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simark@simark.ca>
To: "Maciej W. Rozycki" <macro@embecosm.com>, gdb-patches@sourceware.org
Cc: Andrew Burgess <aburgess@redhat.com>, Tom Tromey <tom@tromey.com>,
	Richard Bunt <Richard.Bunt@arm.com>
Subject: Re: [PATCH] GDB: Fix out of bounds accesses with limited-length values
Date: Thu, 23 Feb 2023 16:34:10 -0500	[thread overview]
Message-ID: <62b3feea-91ba-7fbb-1f6d-115902dc9bf6@simark.ca> (raw)
In-Reply-To: <alpine.DEB.2.20.2302231218190.15477@tpp.orcam.me.uk>

On 2/23/23 16:14, Maciej W. Rozycki wrote:
> Fix accesses to limited-length values in `contents_copy_raw' and 
> `contents_copy_raw_bitwise' so that they observe the limit of the 
> original allocation.
> 
> Reported by Simon Marchi as a heap-buffer-overflow AddressSanitizer 
> issue triggered with gdb.ada/limited-length.exp.
> ---
> Hi,
> 
>  Verified to remove the original issue and not to cause any regressions
> with and w/o AddressSanitizer and native `x86_64-linux-gnu'.  OK to apply?
> 
>   Maciej

Thanks, that LGTM:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon

  reply	other threads:[~2023-02-23 21:34 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-23 21:14 Maciej W. Rozycki
2023-02-23 21:34 ` Simon Marchi [this message]
2023-02-24 12:39   ` Maciej W. Rozycki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=62b3feea-91ba-7fbb-1f6d-115902dc9bf6@simark.ca \
    --to=simark@simark.ca \
    --cc=Richard.Bunt@arm.com \
    --cc=aburgess@redhat.com \
    --cc=gdb-patches@sourceware.org \
    --cc=macro@embecosm.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).