Re: [PATCH] gdb/solib-rocm: limit the number of opened file descriptors

[Lancelot SIX <Lancelot.Six@amd.com>]

Hi Pedro,

Thanks for the review.  I have addressed you minor remarks locally.

>> +
>> +  if (it == m_cache.end ())
>> +    {
>> +      *target_errno = FILEIO_EBADF;
>> +      return -1;
> 
> Is this case ever not a bug?  Should we assert instead?
> 
> Also, AFAICT, no caller actually check the return value of close.  Looks like
> we could simplify things a bit.  There isn't usually much you can do if
> closing fails, so maybe here ...
> 
> 
>> +    }
>> +
>> +  it->second.refcnt--;
>> +  if (it->second.refcnt == 0)
>> +    {
>> +      int ret = target_fileio_close (it->second.fd, target_errno);
>> +      m_cache.erase (it);
>> +      return ret;
> 
> ... issue a warning, and return void?
> 

Since this close method is similar to close(2) or target_fileio_close, I 
think I prefer to keep its interface similar to the others, if that's ok 
with you.  I have updated the caller of this method to print a warning 
if -1 is returned.

I'll send a V2 with those changed.

Best,
Lancelot.