From: Pedro Alves <pedro@palves.net>
To: Lancelot SIX <Lancelot.Six@amd.com>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com
Subject: Re: [PATCH] gdb/solib-rocm: limit the number of opened file descriptors
Date: Wed, 19 Jul 2023 20:23:33 +0100 [thread overview]
Message-ID: <f2aff6b3-54cd-cb4a-3bbb-dbb60f92fc6e@palves.net> (raw)
In-Reply-To: <63d4d548-9bbc-7f0c-3a3f-e2cb538500a7@amd.com>
On 2023-07-19 18:17, Lancelot SIX wrote:
> Since this close method is similar to close(2) or target_fileio_close, I think I prefer to keep its interface similar to the others, if that's ok with you. I have updated the caller of this method to print a warning if -1 is returned.
>
> I'll send a V2 with those changed.
It just seems to me that if we ever add another place that calls .close(), it'll either end
up with duplicated code to emit the warning, or we'll forget to add a warning. But
it's an easy thing to change if we get to that situation, so I won't insist, and whatever
you end up with is OK.
prev parent reply other threads:[~2023-07-19 19:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-28 14:44 Lancelot Six
2023-07-14 18:58 ` Pedro Alves
2023-07-19 17:17 ` Lancelot SIX
2023-07-19 19:23 ` Pedro Alves [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f2aff6b3-54cd-cb4a-3bbb-dbb60f92fc6e@palves.net \
--to=pedro@palves.net \
--cc=Lancelot.Six@amd.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).