From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Fix two bugs in gdbserver thread name handling
Date: Fri, 15 Dec 2023 10:53:19 -0500 [thread overview]
Message-ID: <63d99b56-ae76-4082-9074-1367506eed27@simark.ca> (raw)
In-Reply-To: <20231215145928.3396394-1-tromey@adacore.com>
On 12/15/23 09:59, Tom Tromey wrote:
> Simon pointed out that my earlier patch to gdbserver's thread name
> code:
>
> commit 07b3255c3bae7126a0d679f957788560351eb236
> Author: Tom Tromey <tom@tromey.com>
> Date: Thu Jul 13 17:28:48 2023 -0600
>
> Filter invalid encodings from Linux thread names
>
> ... introduced a regression. Looking at it, I found another bug as
> well. This patch fixes both of them.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=31153
My intuition is that the changes make sense, but it would be nice if you
could describe the bugs in the commit message, to make sure we're on the
same page.
Simon
next prev parent reply other threads:[~2023-12-15 15:53 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-15 14:59 Tom Tromey
2023-12-15 15:53 ` Simon Marchi [this message]
2023-12-15 16:24 ` Tom Tromey
2024-01-09 14:14 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=63d99b56-ae76-4082-9074-1367506eed27@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).