public inbox for
 help / color / mirror / Atom feed
From: John Baldwin <>
Subject: [PING] [PATCH 0/2] Fix gdb.arch/amd64-gs_base.exp test on FreeBSD
Date: Fri, 3 Mar 2023 09:58:38 -0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 2/17/23 12:02 PM, John Baldwin wrote:
> The gdb.arch/amd64-gs_base.exp test was failing on FreeBSD as it had
> some Linux-specific assumptions.  While looking at this I also found
> that Linux/amd64 treats the fs_base and gs_base as "system" registers,
> but FreeBSD did not.  I originally started by moving the logic from
> Linux/amd64 for these registers into i386_register_reggroup_p so it
> would be consistent across all OS ABIs, but I think it would be better
> to treat these registers as general registers instead which is what
> patch 2 does.
> John Baldwin (2):
>    gdb.arch/amd64-gs_base.exp: Support non-Linux.
>    amd64-linux-tdep: Don't treat fs_base and gs_base as system registers.
>   gdb/amd64-linux-tdep.c                   |  4 +---
>   gdb/testsuite/gdb.arch/amd64-gs_base.exp | 10 ++++------
>   2 files changed, 5 insertions(+), 9 deletions(-)


John Baldwin

  parent reply	other threads:[~2023-03-03 17:58 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-02-17 20:02 John Baldwin
2023-02-17 20:02 ` [PATCH 1/2] gdb.arch/amd64-gs_base.exp: Support non-Linux John Baldwin
2023-02-17 20:02 ` [PATCH 2/2] amd64-linux-tdep: Don't treat fs_base and gs_base as system registers John Baldwin
2023-03-03 17:58 ` John Baldwin [this message]
2023-03-03 19:04   ` [PING] [PATCH 0/2] Fix gdb.arch/amd64-gs_base.exp test on FreeBSD Tom Tromey

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).