Re: [PING] [PATCH 0/2] Fix gdb.arch/amd64-gs_base.exp test on FreeBSD

[Tom Tromey <tom@tromey.com>]

>>>>> "John" == John Baldwin <jhb@FreeBSD.org> writes:

John> On 2/17/23 12:02 PM, John Baldwin wrote:
>> The gdb.arch/amd64-gs_base.exp test was failing on FreeBSD as it had
>> some Linux-specific assumptions.  While looking at this I also found
>> that Linux/amd64 treats the fs_base and gs_base as "system" registers,
>> but FreeBSD did not.  I originally started by moving the logic from
>> Linux/amd64 for these registers into i386_register_reggroup_p so it
>> would be consistent across all OS ABIs, but I think it would be better
>> to treat these registers as general registers instead which is what
>> patch 2 does.
>> John Baldwin (2):
>> gdb.arch/amd64-gs_base.exp: Support non-Linux.
>> amd64-linux-tdep: Don't treat fs_base and gs_base as system registers.
>> gdb/amd64-linux-tdep.c                   |  4 +---
>> gdb/testsuite/gdb.arch/amd64-gs_base.exp | 10 ++++------
>> 2 files changed, 5 insertions(+), 9 deletions(-)

John> Ping.

These make sense to me.  Thank you.

Reviewed-By: Tom Tromey <tom@tromey.com>

Tom