From: Simon Marchi <simon.marchi@polymtl.ca>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [pushed] gdb: remove unused include in infrun.c
Date: Tue, 23 Apr 2024 11:32:43 -0400 [thread overview]
Message-ID: <6659b919-b536-4ef4-9183-bbd2ef4141b4@polymtl.ca> (raw)
In-Reply-To: <87bk60qexm.fsf@tromey.com>
On 2024-04-23 11:25, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
>
> Simon> Remove the gdbcmd.h, which is reported as unused by clangd. Add
> Simon> cli/cli-cmds.h instead, to get access to `cmdlist` and friends.
>
> FWIW gdbcmd.h probably shouldn't exist at all.
Yeah it's clearly a remnant from the past. I tried to get rid of it in
the past, but so many files include it. Perhaps I can just make a
find-and-replace and make these files include cli/cli-cmds.h instead,
that's what most of them need (to access `showlist`, `setlist`, etc).
Simon
prev parent reply other threads:[~2024-04-23 15:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-23 15:19 Simon Marchi
2024-04-23 15:25 ` Tom Tromey
2024-04-23 15:32 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6659b919-b536-4ef4-9183-bbd2ef4141b4@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).