[pushed] gdb: remove unused include in infrun.c

[pushed] gdb: remove unused include in infrun.c

[Simon Marchi]

Remove the gdbcmd.h, which is reported as unused by clangd.  Add
cli/cli-cmds.h instead, to get access to `cmdlist` and friends.

Change-Id: Ic0c60d2f6d3618f1bd9fd80b95ffd7c33c692a04
---
 gdb/infrun.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/gdb/infrun.c b/gdb/infrun.c
index a5030b16376d..d23be9ef9411 100644
--- a/gdb/infrun.c
+++ b/gdb/infrun.c
@@ -18,6 +18,7 @@
    You should have received a copy of the GNU General Public License
    along with this program.  If not, see <http://www.gnu.org/licenses/>.  */
 
+#include "cli/cli-cmds.h"
 #include "displaced-stepping.h"
 #include "infrun.h"
 #include <ctype.h>
@@ -26,7 +27,6 @@
 #include "inferior.h"
 #include "breakpoint.h"
 #include "gdbcore.h"
-#include "gdbcmd.h"
 #include "target.h"
 #include "target-connection.h"
 #include "gdbthread.h"

base-commit: 0de4ba02693b74d9171789a6a624d4b40050a30e
-- 
2.44.0

Re: [pushed] gdb: remove unused include in infrun.c

[Tom Tromey]

>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:

Simon> Remove the gdbcmd.h, which is reported as unused by clangd.  Add
Simon> cli/cli-cmds.h instead, to get access to `cmdlist` and friends.

FWIW gdbcmd.h probably shouldn't exist at all.

Tom

Re: [pushed] gdb: remove unused include in infrun.c

[Simon Marchi]

On 2024-04-23 11:25, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi <simon.marchi@polymtl.ca> writes:
> 
> Simon> Remove the gdbcmd.h, which is reported as unused by clangd.  Add
> Simon> cli/cli-cmds.h instead, to get access to `cmdlist` and friends.
> 
> FWIW gdbcmd.h probably shouldn't exist at all.

Yeah it's clearly a remnant from the past.  I tried to get rid of it in
the past, but so many files include it.  Perhaps I can just make a
find-and-replace and make these files include cli/cli-cmds.h instead,
that's what most of them need (to access `showlist`, `setlist`, etc).

Simon