From: Simon Marchi <simon.marchi@polymtl.ca>
To: Aaron Merey <amerey@redhat.com>,
gdb-patches@sourceware.org, tom@tromey.com
Subject: Re: [PATCH 1/3] gdb/solib: Refactor scan_dyntag
Date: Tue, 17 Aug 2021 09:28:52 -0400 [thread overview]
Message-ID: <6695ada0-2820-56ff-cec3-d185d3f5e966@polymtl.ca> (raw)
In-Reply-To: <20210812042406.75637-2-amerey@redhat.com>
On 2021-08-12 12:24 a.m., Aaron Merey wrote:
> scan_dyntag is unnecessarily duplicated in solib-svr4.c and solib-dsbt.c.
>
> Move this function to solib.c and rename it to gdb_bfd_scan_elf_dyntag.
> Also add it to solib.h so it is included in both solib-svr4 and solib-dsbt.
Thanks, this is OK, and I think it can be merged on its own.
Simon
next prev parent reply other threads:[~2021-08-17 13:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-12 4:24 [PATCH v3 0/3] Add debuginfod core file support Aaron Merey
2021-08-12 4:24 ` [PATCH 1/3] gdb/solib: Refactor scan_dyntag Aaron Merey
2021-08-17 13:28 ` Simon Marchi [this message]
2021-08-19 2:30 ` Aaron Merey
2021-08-12 4:24 ` [PATCH 2/3] gdb: Add soname to build-id mapping for corefiles Aaron Merey
2021-08-15 14:51 ` Lancelot SIX
2021-08-17 13:58 ` Simon Marchi
2021-08-19 2:22 ` Aaron Merey
2021-09-29 1:12 ` Aaron Merey
2021-10-18 23:06 ` [PING**2][PATCH " Aaron Merey
2021-11-03 18:12 ` [PING**3][PATCH " Aaron Merey
2021-11-04 1:32 ` [PATCH " Simon Marchi
2021-08-12 4:24 ` [PATCH 3/3] PR gdb/27570: missing support for debuginfod in core_target::build_file_mappings Aaron Merey
2021-09-29 1:13 ` Aaron Merey
2021-10-18 23:05 ` [PING**2][PATCH " Aaron Merey
2021-11-03 18:11 ` [PING**3][PATCH " Aaron Merey
2021-11-04 1:37 ` [PATCH " Simon Marchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6695ada0-2820-56ff-cec3-d185d3f5e966@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).