From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Clean up unusual code in mi-cmd-stack.c
Date: Wed, 25 Jan 2023 13:14:32 -0500 [thread overview]
Message-ID: <67a9bf80-87b5-0a62-49ad-a9cac8ca6109@simark.ca> (raw)
In-Reply-To: <20230125150609.3987536-1-tromey@adacore.com>
On 1/25/23 10:06, Tom Tromey via Gdb-patches wrote:
> I noticed some unusual code in mi-cmd-stack.c. This code is a switch,
> where one of the cases appears in the middle of another block. It
> seemed cleaner to me to have the earlier case just conditionally fall
> through.
Thanks, that LGTM. I would have been very confused if I had to deal
with that code.
Simon
prev parent reply other threads:[~2023-01-25 18:14 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-25 15:06 Tom Tromey
2023-01-25 18:14 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=67a9bf80-87b5-0a62-49ad-a9cac8ca6109@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).