Re: [PATCH v2 1/1] gdb, infcmd: Support jump command with same line in multiple symtabs

[Bruno Larsen <blarsen@redhat.com>]

On 17/04/2023 13:33, Puputti, Matti wrote:
> Hi Bruno,
>
> I have just now uploaded third patch, with updated commit message.
> https://sourceware.org/pipermail/gdb-patches/2023-April/198912.html
>
> If you are good with the new patch, may I ask a favour: can you please push it for me?  I don't have write access, as this this is my first patch series (potentially) to be approved.

Hi Matti,

I don't have the authority to actually approve patches for merging, I 
just review them as a way to signal to the maintainers who can actually 
approve that it has passed my review and so (hopefully) doesn't contain 
obvious mistakes, making their lives easier. The tag you'd be looking 
for is Approved-by. Sorry if this was confusing

-- 
Cheers,
Bruno

>
> Br,
> Matti Puputti
>
>> -----Original Message-----
>> From: Bruno Larsen <blarsen@redhat.com>
>> Sent: Monday, April 17, 2023 12:17 PM
>> To: Puputti, Matti <matti.puputti@intel.com>; gdb-patches@sourceware.org
>> Subject: Re: [PATCH v2 1/1] gdb, infcmd: Support jump command with same line
>> in multiple symtabs
>>
>> Hi Matti,
>>
>> Only some small nits on the commit message:
>>
>> On 14/04/2023 16:15, Matti Puputti wrote:
>>> For example, a header file defining a static function is included in multiple
>> Starting with "If a header (...)" makes more sense in my opinion
>>> source files, each calling the function.  When debugger is asked to jump to
>> "When the debugger" or "When GDB" would flow better
>>> a line inside that function, there would be multiple locations matching the
>>> target.  Solution in this commit is to select the location in the current
>> "The solution in this commit", as mentioend above
>>> symtab.
>> With these changes, I'm fine with giving you my tag:
>> Reviewed-By: Bruno Larsen <blarsen@redhat.com>
>>
>> --
>> Cheers,
>> Bruno
>>
> Intel Deutschland GmbH
> Registered Address: Am Campeon 10, 85579 Neubiberg, Germany
> Tel: +49 89 99 8853-0, www.intel.de <http://www.intel.de>
> Managing Directors: Christin Eisenschmid, Sharon Heck, Tiffany Doon Silva
> Chairperson of the Supervisory Board: Nicole Lau
> Registered Office: Munich
> Commercial Register: Amtsgericht Muenchen HRB 186928