From: Simon Marchi <simon.marchi@polymtl.ca>
To: gdb-patches@sourceware.org
Subject: Re: [PATCH 0/4] Add logging for event loop events
Date: Fri, 2 Oct 2020 14:49:00 -0400 [thread overview]
Message-ID: <6cde0401-2461-0619-023f-1ce80a8b708f@polymtl.ca> (raw)
In-Reply-To: <20200925154831.2759299-1-simon.marchi@polymtl.ca>
On 2020-09-25 11:48 a.m., Simon Marchi wrote:
> I currently have both hands in event loop / infrun stuff, and I found
> it useful to add debug prints to know when the event loop invoked an
> event handler. I would like to propose this for upstream, so that I
> don't need to maintain my own patch on the side :).
>
> Simon Marchi (4):
> gdb: give names to event loop file handlers
> gdb: give names to async event/signal handlers
> gdb: move debug_prefixed_vprintf to gdbsupport
> gdb: add debug prints in event loop
>
> gdb/async-event.c | 49 +++++++++++++++++++++++-----
> gdb/async-event.h | 15 ++++++---
> gdb/debug.c | 13 +-------
> gdb/debug.h | 32 ------------------
> gdb/event-top.c | 67 +++++++++++++++++++++++++++++++++-----
> gdb/infrun.c | 5 +--
> gdb/linux-nat.c | 5 +--
> gdb/record-btrace.c | 2 +-
> gdb/record-full.c | 2 +-
> gdb/remote-notif.c | 2 +-
> gdb/remote.c | 3 +-
> gdb/run-on-main-thread.c | 3 +-
> gdb/ser-base.c | 6 ++--
> gdb/top.c | 4 +++
> gdb/top.h | 3 ++
> gdb/tui/tui-io.c | 2 +-
> gdb/tui/tui-win.c | 3 +-
> gdbserver/linux-low.cc | 3 +-
> gdbserver/remote-utils.cc | 10 +++---
> gdbserver/server.cc | 15 +++++++++
> gdbsupport/common-debug.cc | 11 +++++++
> gdbsupport/common-debug.h | 6 ++++
> gdbsupport/event-loop.cc | 60 +++++++++++++++++++++++++---------
> gdbsupport/event-loop.h | 54 ++++++++++++++++++++++++++++--
> 24 files changed, 274 insertions(+), 101 deletions(-)
> delete mode 100644 gdb/debug.h
>
> --
> 2.28.0
>
I pushed this. Note that I received an informal +1 from Luis on IRC :).
Simon
prev parent reply other threads:[~2020-10-02 18:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 15:48 Simon Marchi
2020-09-25 15:48 ` [PATCH 1/4] gdb: give names to event loop file handlers Simon Marchi
2020-09-25 15:48 ` [PATCH 2/4] gdb: give names to async event/signal handlers Simon Marchi
2020-09-25 15:48 ` [PATCH 3/4] gdb: move debug_prefixed_vprintf to gdbsupport Simon Marchi
2020-09-25 15:48 ` [PATCH 4/4] gdb: add debug prints in event loop Simon Marchi
2020-10-02 18:49 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6cde0401-2461-0619-023f-1ce80a8b708f@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).