Re: [PATCH] Avoid complaint warning on mingw

[Simon Marchi <simark@simark.ca>]

On 4/9/24 11:46 AM, Tom Tromey wrote:
> @@ -418,7 +429,7 @@ extern warning_hook_handler get_warning_hook_handler ();
>     instance of this class with the 'warn' function, and all warnings can be
>     emitted with a single call to 'emit'.  */
>  
> -struct deferred_warnings
> +struct deferred_warnings final : public warning_hook_handler_type
>  {
>    deferred_warnings ()
>      : m_can_style (gdb_stderr->can_emit_style_escape ())
> @@ -444,18 +455,11 @@ struct deferred_warnings
>       hook; see scoped_restore_warning_hook.  Note that no locking is
>       done, so users have to be careful to only install this into a
>       single thread at a time.  */
> -  void operator() (const char *format, va_list args)
> +  void warn (const char *format, va_list args) override
> +    ATTRIBUTE_PRINTF (2, 0)

The `warn (const char *format, ...)` method should probably defer to the
`warn (const char *format, va_list args)` method, they appear to do the
exact same thing.

Otherwise, LGTM:

Approved-By: Simon Marchi <simon.marchi@efficios.com>

Simon