From: Simon Marchi <simark@simark.ca>
To: Luis Machado <luis.machado@arm.com>, gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com, thiago.bauermann@linaro.org
Subject: Re: [PATCH,v3] [aarch64] Fix removal of non-address bits for PAuth
Date: Mon, 12 Dec 2022 10:07:30 -0500 [thread overview]
Message-ID: <6f1c7059-efd6-cd2a-f0c6-de8f182df468@simark.ca> (raw)
In-Reply-To: <bdcae5e1-d01d-ee47-e3f9-2e03accb3e6d@arm.com>
On 12/12/22 09:21, Luis Machado wrote:
> Hi Simon,
>
> On 12/9/22 19:14, Simon Marchi wrote:
>>> @@ -1961,6 +1962,47 @@ aarch64_linux_decode_memtag_section (struct gdbarch *gdbarch,
>>> return tags;
>>> }
>>> +/* AArch64 implementation of the remove_non_address_bits gdbarch hook. Remove
>>> + non address bits from a pointer value. */
>>> +
>>> +static CORE_ADDR
>>> +aarch64_remove_non_address_bits (struct gdbarch *gdbarch, CORE_ADDR pointer)
>>> +{
>>> + aarch64_gdbarch_tdep *tdep = gdbarch_tdep<aarch64_gdbarch_tdep> (gdbarch);
>>> +
>>> + /* By default, we assume TBI and discard the top 8 bits plus the VA range
>>> + select bit (55). */
>>> + CORE_ADDR mask = AARCH64_TOP_BITS_MASK;
>> Declare mask in the context where it's needed.
>>
>
> I decided to declare it here in case we skip the if block, then we return the default value.
>
> Did you have something else in mind?
I missed that it was used in the return value, sorry.
Simon
next prev parent reply other threads:[~2022-12-12 15:07 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 14:00 [PATCH] [AArch64] " Luis Machado
2022-07-05 18:12 ` John Baldwin
2022-07-06 11:38 ` Lancelot SIX
2022-07-08 11:36 ` Luis Machado
2022-07-11 11:55 ` [PATCH,v2] [aarch64] " Luis Machado
2022-07-18 8:16 ` [Ping v1][PATCH,v2] " Luis Machado
2022-08-01 11:09 ` [Ping v2][PATCH,v2] " Luis Machado
2022-08-08 11:34 ` [Ping v3][PATCH,v2] " Luis Machado
2022-08-18 15:49 ` [Ping v4][PATCH,v2] " Luis Machado
2022-08-18 23:47 ` [PATCH,v2] " Thiago Jung Bauermann
2022-08-19 9:52 ` Luis Machado
2022-08-19 14:06 ` Thiago Jung Bauermann
2022-08-23 20:29 ` [PATCH,v3] " Luis Machado
2022-08-24 18:44 ` Thiago Jung Bauermann
2022-09-01 9:29 ` [PING][PATCH,v3] " Luis Machado
2022-09-07 8:21 ` Luis Machado
2022-09-12 12:47 ` Luis Machado
2022-09-20 12:26 ` Luis Machado
2022-09-22 12:59 ` [PATCH,v3] " Lancelot SIX
2022-09-22 16:39 ` Luis Machado
2022-09-23 7:58 ` Lancelot SIX
2022-10-03 11:37 ` [PING][PATCH,v3] " Luis Machado
2022-10-10 12:18 ` Luis Machado
2022-10-17 10:04 ` Luis Machado
2022-10-25 13:52 ` Luis Machado
2022-11-10 1:00 ` Luis Machado
2022-11-29 22:19 ` Luis Machado
2022-12-09 16:42 ` Luis Machado
2022-12-09 19:14 ` [PATCH,v3] " Simon Marchi
2022-12-12 14:21 ` Luis Machado
2022-12-12 15:07 ` Simon Marchi [this message]
2022-12-12 17:13 ` [PATCH v4] " Luis Machado
2022-12-12 18:54 ` Simon Marchi
2022-12-13 9:18 ` Luis Machado
2022-12-13 10:27 ` [PATCH v5] " Luis Machado
2022-12-16 10:57 ` [PATCH v6] " Luis Machado
2022-12-16 11:20 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6f1c7059-efd6-cd2a-f0c6-de8f182df468@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
--cc=luis.machado@arm.com \
--cc=thiago.bauermann@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).