From: Luis Machado <luis.machado@arm.com>
To: Lancelot SIX <lsix@lancelotsix.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] [AArch64] Fix removal of non-address bits for PAuth
Date: Fri, 8 Jul 2022 12:36:06 +0100 [thread overview]
Message-ID: <533c9a59-1755-f260-3c56-2c68003e25d6@arm.com> (raw)
In-Reply-To: <20220706113857.a6gfmmlaeprg5uyq@ubuntu.lan>
On 7/6/22 12:38, Lancelot SIX wrote:
>> +
>> +/* See arch/aarch64.h. */
>> +
>> +CORE_ADDR
>> +aarch64_remove_top_bytes (CORE_ADDR pointer, CORE_ADDR mask)
>
> Hi,
>
> Shouldn't this function be called aarch64_remove_top_bits (note the
> s/bytes/bits)? This function does not work at the byte grain.
>
>
It should! I think I had the TBI (top byte ignore) in mind and then byte was stuck
in my head. Thanks, I'll update this.
>> +{
>> + /* The VA range select bit is 55. This bit tells us if we have a
>> + kernel-space address or a user-space address. */
>> + bool kernel_address = (pointer & VA_RANGE_SELECT_BIT_MASK)? true : false;
>
> You could drop the ternary operator by using
>
> bool kernel_address = (pointer & VA_RANGE_SELECT_BIT_MASK) != 0;
>
> which I find a "more canonical" way to write it, but I guess it is
> mostly a matter of taste.
Yeah. I don't mind either way.
next prev parent reply other threads:[~2022-07-08 11:36 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-07-05 14:00 Luis Machado
2022-07-05 18:12 ` John Baldwin
2022-07-06 11:38 ` Lancelot SIX
2022-07-08 11:36 ` Luis Machado [this message]
2022-07-11 11:55 ` [PATCH,v2] [aarch64] " Luis Machado
2022-07-18 8:16 ` [Ping v1][PATCH,v2] " Luis Machado
2022-08-01 11:09 ` [Ping v2][PATCH,v2] " Luis Machado
2022-08-08 11:34 ` [Ping v3][PATCH,v2] " Luis Machado
2022-08-18 15:49 ` [Ping v4][PATCH,v2] " Luis Machado
2022-08-18 23:47 ` [PATCH,v2] " Thiago Jung Bauermann
2022-08-19 9:52 ` Luis Machado
2022-08-19 14:06 ` Thiago Jung Bauermann
2022-08-23 20:29 ` [PATCH,v3] " Luis Machado
2022-08-24 18:44 ` Thiago Jung Bauermann
2022-09-01 9:29 ` [PING][PATCH,v3] " Luis Machado
2022-09-07 8:21 ` Luis Machado
2022-09-12 12:47 ` Luis Machado
2022-09-20 12:26 ` Luis Machado
2022-09-22 12:59 ` [PATCH,v3] " Lancelot SIX
2022-09-22 16:39 ` Luis Machado
2022-09-23 7:58 ` Lancelot SIX
2022-10-03 11:37 ` [PING][PATCH,v3] " Luis Machado
2022-10-10 12:18 ` Luis Machado
2022-10-17 10:04 ` Luis Machado
2022-10-25 13:52 ` Luis Machado
2022-11-10 1:00 ` Luis Machado
2022-11-29 22:19 ` Luis Machado
2022-12-09 16:42 ` Luis Machado
2022-12-09 19:14 ` [PATCH,v3] " Simon Marchi
2022-12-12 14:21 ` Luis Machado
2022-12-12 15:07 ` Simon Marchi
2022-12-12 17:13 ` [PATCH v4] " Luis Machado
2022-12-12 18:54 ` Simon Marchi
2022-12-13 9:18 ` Luis Machado
2022-12-13 10:27 ` [PATCH v5] " Luis Machado
2022-12-16 10:57 ` [PATCH v6] " Luis Machado
2022-12-16 11:20 ` Luis Machado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=533c9a59-1755-f260-3c56-2c68003e25d6@arm.com \
--to=luis.machado@arm.com \
--cc=gdb-patches@sourceware.org \
--cc=lsix@lancelotsix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).