public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Lancelot SIX <Lancelot.Six@amd.com>
To: gdb-patches@sourceware.org
Cc: lsix@lancelotsix.com, tom@tromey.com
Subject: Re: [PATCH] gdb: Use SYS_DOMAIN instead of DOMAIN when calling sym-domains.def
Date: Mon, 29 Jan 2024 18:40:03 +0000	[thread overview]
Message-ID: <73bfff2e-a102-4676-a034-d1cdf8d71138@amd.com> (raw)
In-Reply-To: <20240129183715.761022-1-lancelot.six@amd.com>



On 29/01/2024 18:37, Lancelot SIX wrote:
> Since commit 6771fc6f1d9 "Use a .def file for domain_enum", the
> sym-domains.def file has been introduced, and requires the user to
> define the DOMAIN(x) macro.
> 
> On older systems (centos-7 with glibc-1.17 for example), this DOMAIN
                                         ^
This should be 2.17.  I fixed this locally.

> macro conflicts with another macro defined in /usr/include/math.h.
> 
> Fix this conflict by changing sym-domains.def to use a macro named
> SYM_DOMAIN instead of DOMAIN.

  reply	other threads:[~2024-01-29 18:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 18:37 Lancelot SIX
2024-01-29 18:40 ` Lancelot SIX [this message]
2024-01-29 19:13 ` Tom Tromey
2024-01-29 20:23   ` [PATCH] gdb: Use SYM_DOMAIN " Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=73bfff2e-a102-4676-a034-d1cdf8d71138@amd.com \
    --to=lancelot.six@amd.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lsix@lancelotsix.com \
    --cc=tom@tromey.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).