public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Tom Tromey <tom@tromey.com>
To: Lancelot SIX <lancelot.six@amd.com>
Cc: <gdb-patches@sourceware.org>,  <lsix@lancelotsix.com>,  <tom@tromey.com>
Subject: Re: [PATCH] gdb: Use SYS_DOMAIN instead of DOMAIN when calling sym-domains.def
Date: Mon, 29 Jan 2024 12:13:42 -0700	[thread overview]
Message-ID: <874jewgdg9.fsf@tromey.com> (raw)
In-Reply-To: <20240129183715.761022-1-lancelot.six@amd.com> (Lancelot SIX's message of "Mon, 29 Jan 2024 18:37:15 +0000")

>>>>> "Lancelot" == Lancelot SIX <lancelot.six@amd.com> writes:

Lancelot> Since commit 6771fc6f1d9 "Use a .def file for domain_enum", the
Lancelot> sym-domains.def file has been introduced, and requires the user to
Lancelot> define the DOMAIN(x) macro.

Lancelot> On older systems (centos-7 with glibc-1.17 for example), this DOMAIN
Lancelot> macro conflicts with another macro defined in /usr/include/math.h.

Lancelot> Fix this conflict by changing sym-domains.def to use a macro named
Lancelot> SYM_DOMAIN instead of DOMAIN.

Thanks.
Approved-By: Tom Tromey <tom@tromey.com>

Tom

  parent reply	other threads:[~2024-01-29 19:13 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-01-29 18:37 Lancelot SIX
2024-01-29 18:40 ` Lancelot SIX
2024-01-29 19:13 ` Tom Tromey [this message]
2024-01-29 20:23   ` [PATCH] gdb: Use SYM_DOMAIN " Lancelot SIX

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874jewgdg9.fsf@tromey.com \
    --to=tom@tromey.com \
    --cc=gdb-patches@sourceware.org \
    --cc=lancelot.six@amd.com \
    --cc=lsix@lancelotsix.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).