From: Simon Marchi <simon.marchi@efficios.com>
To: Tom Tromey <tom@tromey.com>,
Simon Marchi via Gdb-patches <gdb-patches@sourceware.org>
Cc: Simon Marchi <simon.marchi@polymtl.ca>
Subject: Re: [PATCH] gdb/dwarf: dump cooked index contents in cooked_index_functions::dump
Date: Fri, 27 Jan 2023 11:03:03 -0500 [thread overview]
Message-ID: <73cc8a21-9511-ac28-c8c1-45e4195dd880@efficios.com> (raw)
In-Reply-To: <87mt64qcmh.fsf@tromey.com>
> Simon> +
> Simon> + dwarf2_per_objfile *per_objfile = get_dwarf2_per_objfile (objfile);
> Simon> +
> Simon> + cooked_index_vector *table
> Simon> + = (gdb::checked_static_cast<cooked_index_vector *>
> Simon> + (per_objfile->per_bfd->index_table.get ()));
>
> Like right here could be a method call.
>
> The cooked index dumper should probably start with a call to 'wait' to
> ensure that no background work is being done.
Ah, that makes sense.
> Simon> + const char *start_addr_str
> Simon> + = paddress (current_inferior ()->gdbarch, start_addr);
>
> I was curious why the inferior.h include was needed.
> I suspect the objfile's arch is preferred here.
Ah, I forgot that objfiles had arches. Makes sense.
I'll send a v2 with those fixed.
Simon
prev parent reply other threads:[~2023-01-27 16:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-27 5:13 Simon Marchi
2023-01-27 10:34 ` Andrew Burgess
2023-01-27 14:24 ` Tom Tromey
2023-01-27 16:03 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=73cc8a21-9511-ac28-c8c1-45e4195dd880@efficios.com \
--to=simon.marchi@efficios.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@polymtl.ca \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).