public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
* [PATCH] gdb: Fix installation of gcore.1 on some platforms
@ 2020-10-06 20:43 Michael Forney
  2020-10-07  2:32 ` Simon Marchi
  0 siblings, 1 reply; 2+ messages in thread
From: Michael Forney @ 2020-10-06 20:43 UTC (permalink / raw)
  To: gdb-patches

gcore is installed on NetBSD, FreeBSD, Solaris (HAVE_NATIVE_GCORE_HOST=1)
and Linux (HAVE_NATIVE_GCORE_TARGET=1). However, even though gcore.1
is installed conditional on those variables, HAVE_NATIVE_GCORE_HOST
was missing from gdb/doc/Makefile.in, so manual installation was
skipped on NetBSD, FreeBSD, and Solaris.

gdb/doc/ChangeLog:
2020-10-06  Michael Forney  <mforney@mforney.org>

        * Makefile.in (HAVE_NATIVE_GCORE_HOST): Add for gcore.1
        install condition.
---
 gdb/doc/Makefile.in | 1 +
 1 file changed, 1 insertion(+)

diff --git a/gdb/doc/Makefile.in b/gdb/doc/Makefile.in
index 65b5eaa91e..3d10dee1bd 100644
--- a/gdb/doc/Makefile.in
+++ b/gdb/doc/Makefile.in
@@ -180,6 +180,7 @@ MAN5S = gdbinit.5
 MANS = $(MAN1S) $(MAN5S)
 
 HAVE_NATIVE_GCORE_TARGET = @HAVE_NATIVE_GCORE_TARGET@
+HAVE_NATIVE_GCORE_HOST = @HAVE_NATIVE_GCORE_HOST@
 
 ###
 
-- 
2.28.0


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] gdb: Fix installation of gcore.1 on some platforms
  2020-10-06 20:43 [PATCH] gdb: Fix installation of gcore.1 on some platforms Michael Forney
@ 2020-10-07  2:32 ` Simon Marchi
  0 siblings, 0 replies; 2+ messages in thread
From: Simon Marchi @ 2020-10-07  2:32 UTC (permalink / raw)
  To: Michael Forney, gdb-patches

On 2020-10-06 4:43 p.m., Michael Forney wrote:
> gcore is installed on NetBSD, FreeBSD, Solaris (HAVE_NATIVE_GCORE_HOST=1)
> and Linux (HAVE_NATIVE_GCORE_TARGET=1). However, even though gcore.1
> is installed conditional on those variables, HAVE_NATIVE_GCORE_HOST
> was missing from gdb/doc/Makefile.in, so manual installation was
> skipped on NetBSD, FreeBSD, and Solaris.

Thanks, that looks right, I pushed it.

Simon

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-10-07  2:32 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-06 20:43 [PATCH] gdb: Fix installation of gcore.1 on some platforms Michael Forney
2020-10-07  2:32 ` Simon Marchi

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).