Re: [PATCH] gdbsupport: change path_join parameter to std::vector<const char *>

[Simon Marchi <simon.marchi@efficios.com>]

On 2022-09-21 11:31, Tom Tromey wrote:
>>>>>> "Simon" == Simon Marchi via Gdb-patches <gdb-patches@sourceware.org> writes:
> 
> Simon> When a GDB built with -D_GLIBCXX_DEBUG=1 reads a binary with a single
> Simon> character name, we hit this assertion failure:
> [...]
> 
> Simon> This patch makes the easy fix, that is to change the path_join parameter
> Simon> from a vector of to a vector of `const char *`.  Another solution would
> Simon> be to introduce a non-standard gdb::cstring_view class, which would be a
> Simon> view over a null-terminated string.  With that class, it would be
> Simon> correct to access index 1, it would yield the NUL character.  If there
> Simon> is interest in having this class (it has been mentioned a few times in
> Simon> the past) I can do it and use it here.
> 
> I think it's fine to just do this for the time being.
> Thank you.

I had forgotten about that patch, thanks.  I also realized the subject is
wrong, it should be array_view instead of vector.  Will push with that
fixed.

Simon