public inbox for gdb-patches@sourceware.org
 help / color / mirror / Atom feed
From: Simon Marchi <simon.marchi@efficios.com>
To: Pedro Alves <pedro@palves.net>, gdb-patches@sourceware.org
Subject: Re: [PATCH 2/2] gdb/doc: describe x87 registers
Date: Fri, 8 Sep 2023 13:16:07 -0400	[thread overview]
Message-ID: <7ddbf9fb-b016-47f1-ba6f-3a8d71b92922@efficios.com> (raw)
In-Reply-To: <f6d283eb-260a-0728-2118-70329b788b17@palves.net>

On 9/8/23 13:03, Pedro Alves wrote:
> On 2023-09-08 16:20, Simon Marchi via Gdb-patches wrote:
>> While investigating this [1], I initially had no idea what register
>> "fioff" stood for, making it difficult to map it to something in the
>> Intel or AMD manuals.  Similarly, I can imaging someone familiar with
>> x87 to want to print the "x87 last instruction address", and have no
>> clue that GDB makes it available as register "fioff".  The names of the
>> x87 state fields don't seem to be standardized, they even change between
>> sections of the Intel manual (between the FSAVE, FXSAVE and XSAVE area
>> descriptions).
>>
>> Add some details to the doc to help one map GDB register names to x87
>> state fields.
>>
> 
> Thanks for implementing this!  Just one nit below:
> 
>> +@subsubsection x87 registers
>> +
>> +GDB provides access to the x87 state through the following registers:
> 
> GDB -> @value{GDBN}
> 

Thanks, fixed and pushed.

Simon

  reply	other threads:[~2023-09-08 17:16 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-09-08 15:20 [PATCH 1/2] gdb/doc: rename "x86 Architecture-specific Issues" section to "x86" Simon Marchi
2023-09-08 15:20 ` [PATCH 2/2] gdb/doc: describe x87 registers Simon Marchi
2023-09-08 15:35   ` Eli Zaretskii
2023-09-08 17:03   ` Pedro Alves
2023-09-08 17:16     ` Simon Marchi [this message]
2023-09-08 15:37 ` [PATCH 1/2] gdb/doc: rename "x86 Architecture-specific Issues" section to "x86" Eli Zaretskii
2023-09-08 17:17   ` Simon Marchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ddbf9fb-b016-47f1-ba6f-3a8d71b92922@efficios.com \
    --to=simon.marchi@efficios.com \
    --cc=gdb-patches@sourceware.org \
    --cc=pedro@palves.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).