From: Tsukasa OI <research_trasio@irq.a4lg.com>
To: Mike Frysinger <vapier@gentoo.org>, gdb-patches@sourceware.org
Subject: Re: [RESEND PATCH 0/1] sim/testsuite: Trim extra path from arch
Date: Mon, 24 Oct 2022 15:31:03 +0900 [thread overview]
Message-ID: <7e383f23-1568-2129-d717-2b7fc45f860b@irq.a4lg.com> (raw)
In-Reply-To: <Y1WTDDkd6ToKlyXT@vapier>
On 2022/10/24 4:16, Mike Frysinger wrote:
> On 27 Aug 2022 01:53, Tsukasa OI wrote:
>> The patch is a RESEND of
>> <https://sourceware.org/pipermail/binutils/2022-July/121814.html>
>> but to the right mailing list and completely new cover letter.
>
> please clean up the patch and send it out standalone -- no need for a cover
> letter, and the relevant details should all be in the patch itself.
Sorry, I should have at least enhanced the commit message (I would have
attached a separate cover letter for information not relevant to the
change itself).
>
>> 1. Configure Binutils with aarch64-unknown-elf and build it
>> /src/binutils/configure \
>> --target=aarch64-unknown-elf \
>> --prefix=/opt/cross/aarch64-unknown-elf \
>> --enable-multilib
>> && make
>> 2. Run `make check-sim' and confirmed that the simulator tests "pass"
>> 3. Intentionally try to fail the test by modifying
>> `sim/testsuite/aarch64/pass.s'
>> (replace the last line from "pass" to "fail")
>> 4. Run `make check-sim' and "confirmed" that the simulator tests "pass"
>
> since i don't have the same paths as you, i didn't run the same configure.
> but using --target=aarch64-elf and running `make check-sim` with -j1 vs -j4
> doesn't show any behavior difference. all the tests are found & run. if i
> add an error to one of the tests like you did, it fails in both modes.
>
> $ runtest --version
> DejaGnu version 1.6.3
> Expect version 5.45.4
> Tcl version 8.6
>
>> However, this block doesn't work because the `arch' variable returned by
>> the `sim_arch' function is "./aarch64". That is supposed to be "aarch64".
>
> i don't mind fixing sim_arch, but this really should be fixed too. we
> shouldn't be in a situation where "./aarch64" is present as an input.
>
> seems easy enough to do so i pushed a patch for it.
> -mike
That worked perfectly!
I'll withdraw this patchset and close the bug report.
Thanks,
Tsukasa
next prev parent reply other threads:[~2022-10-24 6:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <28df7073ec5a8f601ba47c9d2f7d4a7a0ce08753.1657795051.git.research_trasio@irq.a4lg.com>
2022-08-27 1:53 ` Tsukasa OI
2022-08-27 1:53 ` [RESEND PATCH 1/1] " Tsukasa OI
2022-09-14 10:56 ` [PING^2 PATCH 0/1] " Tsukasa OI
2022-09-14 10:56 ` [PING^2 PATCH 1/1] " Tsukasa OI
2022-09-21 16:02 ` [PING^3 PATCH 0/1] sim/testsuite: Fix broken "make check-sim" by trimming excess " Tsukasa OI
2022-09-21 16:02 ` [PING^3 PATCH 1/1] sim/testsuite: Trim extra " Tsukasa OI
2022-10-09 3:55 ` [PING^4 PATCH 0/1] sim/testsuite: PR29596, Fix broken "make check-sim" by trimming excess " Tsukasa OI
2022-10-09 3:55 ` [PING^4 PATCH 1/1] sim/testsuite: PR29596, Trim extra " Tsukasa OI
2022-10-11 11:06 ` [PING^4 PATCH 0/1] sim/testsuite: PR29596, Fix broken "make check-sim" by trimming excess " Andrew Burgess
2022-10-12 5:39 ` Tsukasa OI
2022-10-16 13:01 ` Tsukasa OI
2022-10-23 19:16 ` [RESEND PATCH 0/1] sim/testsuite: Trim extra " Mike Frysinger
2022-10-24 6:31 ` Tsukasa OI [this message]
2022-10-24 7:33 ` Mike Frysinger
2022-10-23 19:16 ` [PATCH] sim: testsuite: tweak parallel find invocation [PR sim/29596] Mike Frysinger
2022-10-23 19:44 ` [PATCH] sim: testsuite: update ignored .exp files " Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7e383f23-1568-2129-d717-2b7fc45f860b@irq.a4lg.com \
--to=research_trasio@irq.a4lg.com \
--cc=gdb-patches@sourceware.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).