Re: [PATCH] [gdb/tui] Use more box_width in tui-regs.c

[Tom de Vries <tdevries@suse.de>]

On 12/15/23 16:32, Tom Tromey wrote:
>>>>>> "Tom" == Tom de Vries <tdevries@suse.de> writes:
> 
> Tom>    /* Now create each data "sub" window, and write the display into
> Tom>       it.  */
> Tom> -  int cur_y = 1;
> Tom> +  int cur_y = box_width ();
> 
> It is sort of weird to see the pairing of "y" and "width", but I suppose
> there isn't a "box_height" method.
> 

Yeah, I may have confused width and thickness when choosing that name.

Anyway, looking at one of the PRs you just filed, we may go to a 
hborder/vborder (horizontal/vertical) approach [ or even a 
tborder/bborder/lborder/rborder (top/bottom/left/right) approach ] and I 
suppose that could be a good moment to rectify this misnomer.

> Anyway it seems fine.
> Approved-By: Tom Tromey <tom@tromey.com>

Thanks for the review.

Committed.

Thanks,
- Tom