From: Simon Marchi <simon.marchi@polymtl.ca>
To: Andrew Burgess <aburgess@redhat.com>,
Tom de Vries <tdevries@suse.de>,
gdb-patches@sourceware.org
Subject: Re: [PATCH] [gdb/build] Fix static cast of virtual base
Date: Mon, 11 Mar 2024 12:22:59 -0400 [thread overview]
Message-ID: <7f3d74e0-1825-477d-9842-1d7f7fce221a@polymtl.ca> (raw)
In-Reply-To: <8734sxqd3i.fsf@redhat.com>
On 3/11/24 06:25, Andrew Burgess wrote:
>> This is similar to what I proposed here:
>>
>> https://inbox.sourceware.org/gdb-patches/24af4ea8-5426-4ce4-b1c5-12858b38a952@simark.ca/
>>
>> The idea is the same, to have a static_cast in the DEVELOPMENT branch.
>> I kinda like my version better, as it factors out the static cast
>> (notice that both branches have identical static_cast lines after your
>> patch) and the ifdef is just around a single assert. Also, I'm pretty
>> sure the nullptr check is not necessary, as both dynamic_cast and
>> static_cast can handle it.
>
> I agree yours is better. Do you have an official patch somewhere that I
> can add a +1 too? If not then below is an updated version inline with
> you proposal. Feel free to push your version if you have it somewhere.
I didn't have a proper patch ready, what you sent LGTM. Thanks a lot
for taking care of it.
Simon
next prev parent reply other threads:[~2024-03-11 16:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-22 16:18 Tom de Vries
2024-02-23 13:56 ` Tom Tromey
2024-03-06 17:39 ` Andrew Burgess
2024-03-06 18:27 ` Simon Marchi
2024-03-08 16:18 ` Tom Tromey
2024-03-11 10:25 ` Andrew Burgess
2024-03-11 16:22 ` Simon Marchi [this message]
2024-03-19 14:58 ` Andrew Burgess
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7f3d74e0-1825-477d-9842-1d7f7fce221a@polymtl.ca \
--to=simon.marchi@polymtl.ca \
--cc=aburgess@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).