From: Simon Marchi <simark@simark.ca>
To: Tom Tromey <tromey@adacore.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH] Let user C-c when waiting for DWARF index finalization
Date: Tue, 6 Dec 2022 15:35:14 -0500 [thread overview]
Message-ID: <7fa32516-85f5-8809-93d7-d2e95607f7e2@simark.ca> (raw)
In-Reply-To: <20221206192743.2827834-1-tromey@adacore.com>
On 12/6/22 14:27, Tom Tromey via Gdb-patches wrote:
> In PR gdb/29854, Simon pointed out that it would be good to be able to
> use C-c when the DWARF cooked index is waiting for finalization. The
> idea here is to be able to interrupt a command like "break" -- not to
> stop the finalization process itself, which runs in a worker thread.
>
> This patch implements this idea, by changing the index wait functions
> to, by default, allow a quit. Polling is done, because there doesn't
> seem to be a better way to interrupt a wait on a std::future.
>
> Bug: https://sourceware.org/bugzilla/show_bug.cgi?id=29854
Thanks for doing it. It's not mandatory, but it fixes a little
annoyance I hit while debugging GDB with an unoptimized GDB (the
gdb.gdb/selftest.exp test). It's unfortunate that there isn't a nicer
way, but this works.
The patch LGTM, but since I was the one to request to the feature, we
could maybe let someone else review and ack.
Simon
next prev parent reply other threads:[~2022-12-06 20:35 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-06 19:27 Tom Tromey
2022-12-06 20:35 ` Simon Marchi [this message]
2022-12-14 14:49 ` Lancelot SIX
2022-12-14 18:00 ` Tom Tromey
2023-01-27 19:22 ` Tom Tromey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7fa32516-85f5-8809-93d7-d2e95607f7e2@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tromey@adacore.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).