Re: [PATCH] Let user C-c when waiting for DWARF index finalization

[Tom Tromey <tromey@adacore.com>]

>>>>> "Tom" == Tom Tromey via Gdb-patches <gdb-patches@sourceware.org> writes:

Tom> In PR gdb/29854, Simon pointed out that it would be good to be able to
Tom> use C-c when the DWARF cooked index is waiting for finalization.  The
Tom> idea here is to be able to interrupt a command like "break" -- not to
Tom> stop the finalization process itself, which runs in a worker thread.

Tom> This patch implements this idea, by changing the index wait functions
Tom> to, by default, allow a quit.  Polling is done, because there doesn't
Tom> seem to be a better way to interrupt a wait on a std::future.

I'm not totally sure what to do with this patch.
Should it go in GDB 13?

Tom> +void
Tom> +cooked_index::wait (bool allow_quit)
Tom> +{
Tom> +  if (allow_quit)
Tom> +    {
Tom> +      using namespace std::chrono_literals;
Tom> +      auto duration = 15ms;
Tom> +      while (m_future.wait_for (duration) == std::future_status::timeout)

I did belatedly realize this will need an update to the gdb::future
compatibility wrapper.

I'll do a --disable-threading build before patching this.

Tom