From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>, gdb-patches@sourceware.org
Subject: Re: [PATCH 11/30] Return vector of results from parallel_for_each
Date: Fri, 27 Aug 2021 08:20:55 +0200 [thread overview]
Message-ID: <8037d3f0-bec2-b55c-e3e0-f4ceea79527c@suse.de> (raw)
In-Reply-To: <20210826021937.1490292-12-tom@tromey.com>
On 8/26/21 4:19 AM, Tom Tromey wrote:
> - /* Process all the remaining elements in the main thread. */
> - callback (first, last);
> + gdb::detail::par_for_accumulator<result_type> results (n_threads - 1);
This breaks set worker-threads 0:
...
$ gcc hello.c -g
$ gdb -q -batch -iex "maint set worker-threads 0" a.out -ex "b main"
terminate called after throwing an instance of 'std::bad_alloc'
what(): std::bad_alloc
Fatal signal: Aborted
----- Backtrace -----
/home/vries/gdb_versions/devel/gdb[0x6edf36]
/lib64/libc.so.6(+0x394a0)[0x7f8522b704a0]
/lib64/libc.so.6(gsignal+0x110)[0x7f8522b70420]
/lib64/libc.so.6(abort+0x151)[0x7f8522b71a01]
/usr/lib64/libstdc++.so.6(+0xa5016)[0x7f85231b0016]
/usr/lib64/libstdc++.so.6(+0xb08dc)[0x7f85231bb8dc]
/usr/lib64/libstdc++.so.6(+0xb0947)[0x7f85231bb947]
/usr/lib64/libstdc++.so.6(+0xb0be9)[0x7f85231bbbe9]
/usr/lib64/libstdc++.so.6(_ZSt28__throw_bad_array_new_lengthv+0x0)[0x7f85231b27c7]
/home/vries/gdb_versions/devel/gdb[0x878392]
/home/vries/gdb_versions/devel/gdb[0x877d69]
/home/vries/gdb_versions/devel/gdb[0x8778da]
/home/vries/gdb_versions/devel/gdb[0x8774bb]
/home/vries/gdb_versions/devel/gdb[0x876d07]
/home/vries/gdb_versions/devel/gdb[0x876386]
/home/vries/gdb_versions/devel/gdb[0x875c64]
/home/vries/gdb_versions/devel/gdb[0x874c6e]
/home/vries/gdb_versions/devel/gdb[0x8744a2]
/home/vries/gdb_versions/devel/gdb[0x6e1228]
/home/vries/gdb_versions/devel/gdb[0x6e13d9]
/home/vries/gdb_versions/devel/gdb[0xa528a5]
/home/vries/gdb_versions/devel/gdb[0xa52ec2]
/home/vries/gdb_versions/devel/gdb[0xa52f8a]
/home/vries/gdb_versions/devel/gdb[0xa5345d]
/home/vries/gdb_versions/devel/gdb[0xa537d7]
Backtrace might be incomplete.
---------------------
A fatal error internal to GDB has been detected, further
debugging is not possible. GDB will now terminate.
...
The abort happens because:
...
(gdb) up
#14 0x0000000000874c6e in gdb::parallel_for_each<minimal_symbol*,
minimal_symbol_reader::install()::<lambda(minimal_symbol*,
minimal_symbol*)> >(unsigned int, minimal_symbol *, minimal_symbol *,
minimal_symbol_reader::<lambda(minimal_symbol*, minimal_symbol*)>) (n=10,
first=0x2493ad0, last=0x2494388, callback=...)
at
/home/vries/gdb_versions/devel/src/gdb/../gdbsupport/parallel-for.h:159
159 gdb::detail::par_for_accumulator<result_type> results
(n_threads - 1);
(gdb) p n_threads
$3 = 0
(gdb) p n_threads - 1
$1 = 18446744073709551615
...
I guess this hints at the fact that we don't exercise different values
for worker-threads in the testsuite.
Thanks,
- Tom
next prev parent reply other threads:[~2021-08-27 6:20 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 2:19 [PATCH 00/30] Rewrite the DWARF "partial" reader Tom Tromey
2021-08-26 2:19 ` [PATCH 01/30] Introduce make_unique_xstrndup Tom Tromey
2021-08-26 2:19 ` [PATCH 02/30] Split create_addrmap_from_aranges Tom Tromey
2021-08-26 2:19 ` [PATCH 03/30] Add dwarf2_per_cu_data::addresses_seen Tom Tromey
2021-08-26 2:19 ` [PATCH 04/30] Refactor dwarf2_get_pc_bounds Tom Tromey
2021-08-26 2:19 ` [PATCH 05/30] Allow ada_decode not to decode operators Tom Tromey
2021-08-26 2:19 ` [PATCH 06/30] Let skip_one_die not skip children Tom Tromey
2021-08-26 2:19 ` [PATCH 07/30] Add name splitting Tom Tromey
2021-08-26 2:19 ` [PATCH 08/30] Add new overload of dwarf5_djb_hash Tom Tromey
2021-08-26 2:19 ` [PATCH 09/30] Refactor build_type_psymtabs_reader Tom Tromey
2021-08-26 2:19 ` [PATCH 10/30] Add batching parameter to parallel_for_each Tom Tromey
2021-08-26 2:19 ` [PATCH 11/30] Return vector of results from parallel_for_each Tom Tromey
2021-08-27 6:20 ` Tom de Vries [this message]
2021-08-28 19:20 ` Tom Tromey
2021-08-26 2:19 ` [PATCH 12/30] Introduce DWARF abbrev cache Tom Tromey
2021-08-26 2:19 ` [PATCH 13/30] Statically examine abbrev properties Tom Tromey
2021-09-06 22:31 ` Lancelot SIX
2021-11-04 18:00 ` Tom Tromey
2021-08-26 2:19 ` [PATCH 14/30] Update skip_one_die for new " Tom Tromey
2021-08-26 2:19 ` [PATCH 15/30] Introduce the new DWARF index class Tom Tromey
2021-09-09 23:32 ` Lancelot SIX
2021-11-04 18:03 ` Tom Tromey
2021-08-26 2:19 ` [PATCH 16/30] The new DWARF indexer Tom Tromey
2021-08-26 2:19 ` [PATCH 17/30] Implement quick_symbol_functions for cooked DWARF index Tom Tromey
2021-08-26 2:19 ` [PATCH 18/30] Wire in the new DWARF indexer Tom Tromey
2021-08-26 2:19 ` [PATCH 19/30] Pre-read DWARF section data Tom Tromey
2021-08-26 2:19 ` [PATCH 20/30] Parallelize DWARF indexing Tom Tromey
2021-08-26 2:19 ` [PATCH 21/30] "Finalize" the DWARF index in the background Tom Tromey
2021-08-26 2:19 ` [PATCH 22/30] Rename write_psymtabs_to_index Tom Tromey
2021-08-26 2:19 ` [PATCH 23/30] Change the key type in psym_index_map Tom Tromey
2021-08-26 2:19 ` [PATCH 24/30] Change parameters to write_address_map Tom Tromey
2021-08-26 2:19 ` [PATCH 25/30] Genericize addrmap handling in the DWARF index writer Tom Tromey
2021-08-26 2:19 ` [PATCH 26/30] Adapt .gdb_index writer to new DWARF scanner Tom Tromey
2021-08-26 2:19 ` [PATCH 27/30] Adapt .debug_names " Tom Tromey
2021-08-26 2:19 ` [PATCH 28/30] Enable the new DWARF indexer Tom Tromey
2021-08-26 2:19 ` [PATCH 29/30] Delete DWARF psymtab code Tom Tromey
2021-08-26 2:19 ` [PATCH 30/30] Remove dwarf2_per_cu_data::v Tom Tromey
2021-08-26 20:32 ` [PATCH 00/30] Rewrite the DWARF "partial" reader Tom de Vries
2021-08-26 21:29 ` Tom Tromey
2021-08-27 7:31 ` Tom de Vries
2021-08-30 15:04 ` Tom Tromey
2021-09-06 19:46 ` Tom Tromey
2021-09-07 10:58 ` Tom de Vries
2021-09-07 12:16 ` Tom de Vries
2021-10-29 23:06 ` Tom Tromey
2021-09-09 19:00 ` Wei-min Pan
2021-09-11 21:08 ` Tom Tromey
2021-09-13 16:50 ` Weimin Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8037d3f0-bec2-b55c-e3e0-f4ceea79527c@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).