From: Tom de Vries <tdevries@suse.de>
To: Tom Tromey <tom@tromey.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH 00/30] Rewrite the DWARF "partial" reader
Date: Tue, 7 Sep 2021 12:58:43 +0200 [thread overview]
Message-ID: <dd4a83b8-8e7e-09ea-9ca0-921850c1ff44@suse.de> (raw)
In-Reply-To: <875yvdjxmi.fsf@tromey.com>
On 9/6/21 9:46 PM, Tom Tromey wrote:
> Tom> $ total=100; worker_threads=unlimited; pass=0; for n in $(seq 1 $total);
> Tom> do gdb -q -batch -iex "maint set worker-threads $worker_threads"
> Tom> ./outputs/gdb.cp/cpexprs-debug-types/cpexprs-debug-types >LOG 2>ERR; if
> Tom> [ $? -eq 0 ]; then pass=$(($pass + 1)); fi; done; echo "PASS: $pass/$total"
> Tom> PASS: 62/100
>
> Me> Thanks. I was able to reproduce it this way. I'm looking into it.
>
> This one turned out to be a data race due to how type units are handled.
> However, the racy parts are actually unused, and I think can just be
> deleted. The next version of the series will do that, combining a
> couple of patches at the end to make it a bit simpler.
>
> Tom> Dwarf Error: DW_FORM_strp used without required section^M
> Tom> Dwarf Error: DW_FORM_strp used without required section^M
>
> Me> In this case I think one idea is to de-duplicate the errors before
> Me> printing them.
>
> I am going to implement this soon.
>
> I also realized that 'complaint' is not thread-safe, but can be run in
> the worker threads. I have a patch for this now as well.
>
I pulled the series from github once more and did a build and test run.
After fixing a segfault like this:
...
diff --git a/gdb/complaints.c b/gdb/complaints.c
index 095fa3710cd..7b8f865f134 100644
--- a/gdb/complaints.c
+++ b/gdb/complaints.c
@@ -115,6 +115,7 @@ complaint_interceptor::~complaint_interceptor ()
}
g_complaint_interceptor = nullptr;
+ deprecated_warning_hook = m_saved_warning_hook;
}
/* See complaints.h. */
...
I did a regular test run and ran only into the usual suspects, so, no
regressions.
FTR, this did trigger:
...
ERROR: internal buffer is full.
...
in gdb.base/info_sources_2.exp, but that's a known issue with high cpu
load and glibc debug info package.
I then redid the run-in-a-loop experiments that I mentioned earlier in
this thread.
The gdb.cp/cpexprs-debug-types one indeed now passes, the
gdb.dwarf2/fission-multi-cu still fails.
> I hope to send an updated series soon, but I'm not sure exactly when
> yet.
Ack.
Thanks,
- Tom
next prev parent reply other threads:[~2021-09-07 10:58 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-26 2:19 Tom Tromey
2021-08-26 2:19 ` [PATCH 01/30] Introduce make_unique_xstrndup Tom Tromey
2021-08-26 2:19 ` [PATCH 02/30] Split create_addrmap_from_aranges Tom Tromey
2021-08-26 2:19 ` [PATCH 03/30] Add dwarf2_per_cu_data::addresses_seen Tom Tromey
2021-08-26 2:19 ` [PATCH 04/30] Refactor dwarf2_get_pc_bounds Tom Tromey
2021-08-26 2:19 ` [PATCH 05/30] Allow ada_decode not to decode operators Tom Tromey
2021-08-26 2:19 ` [PATCH 06/30] Let skip_one_die not skip children Tom Tromey
2021-08-26 2:19 ` [PATCH 07/30] Add name splitting Tom Tromey
2021-08-26 2:19 ` [PATCH 08/30] Add new overload of dwarf5_djb_hash Tom Tromey
2021-08-26 2:19 ` [PATCH 09/30] Refactor build_type_psymtabs_reader Tom Tromey
2021-08-26 2:19 ` [PATCH 10/30] Add batching parameter to parallel_for_each Tom Tromey
2021-08-26 2:19 ` [PATCH 11/30] Return vector of results from parallel_for_each Tom Tromey
2021-08-27 6:20 ` Tom de Vries
2021-08-28 19:20 ` Tom Tromey
2021-08-26 2:19 ` [PATCH 12/30] Introduce DWARF abbrev cache Tom Tromey
2021-08-26 2:19 ` [PATCH 13/30] Statically examine abbrev properties Tom Tromey
2021-09-06 22:31 ` Lancelot SIX
2021-11-04 18:00 ` Tom Tromey
2021-08-26 2:19 ` [PATCH 14/30] Update skip_one_die for new " Tom Tromey
2021-08-26 2:19 ` [PATCH 15/30] Introduce the new DWARF index class Tom Tromey
2021-09-09 23:32 ` Lancelot SIX
2021-11-04 18:03 ` Tom Tromey
2021-08-26 2:19 ` [PATCH 16/30] The new DWARF indexer Tom Tromey
2021-08-26 2:19 ` [PATCH 17/30] Implement quick_symbol_functions for cooked DWARF index Tom Tromey
2021-08-26 2:19 ` [PATCH 18/30] Wire in the new DWARF indexer Tom Tromey
2021-08-26 2:19 ` [PATCH 19/30] Pre-read DWARF section data Tom Tromey
2021-08-26 2:19 ` [PATCH 20/30] Parallelize DWARF indexing Tom Tromey
2021-08-26 2:19 ` [PATCH 21/30] "Finalize" the DWARF index in the background Tom Tromey
2021-08-26 2:19 ` [PATCH 22/30] Rename write_psymtabs_to_index Tom Tromey
2021-08-26 2:19 ` [PATCH 23/30] Change the key type in psym_index_map Tom Tromey
2021-08-26 2:19 ` [PATCH 24/30] Change parameters to write_address_map Tom Tromey
2021-08-26 2:19 ` [PATCH 25/30] Genericize addrmap handling in the DWARF index writer Tom Tromey
2021-08-26 2:19 ` [PATCH 26/30] Adapt .gdb_index writer to new DWARF scanner Tom Tromey
2021-08-26 2:19 ` [PATCH 27/30] Adapt .debug_names " Tom Tromey
2021-08-26 2:19 ` [PATCH 28/30] Enable the new DWARF indexer Tom Tromey
2021-08-26 2:19 ` [PATCH 29/30] Delete DWARF psymtab code Tom Tromey
2021-08-26 2:19 ` [PATCH 30/30] Remove dwarf2_per_cu_data::v Tom Tromey
2021-08-26 20:32 ` [PATCH 00/30] Rewrite the DWARF "partial" reader Tom de Vries
2021-08-26 21:29 ` Tom Tromey
2021-08-27 7:31 ` Tom de Vries
2021-08-30 15:04 ` Tom Tromey
2021-09-06 19:46 ` Tom Tromey
2021-09-07 10:58 ` Tom de Vries [this message]
2021-09-07 12:16 ` Tom de Vries
2021-10-29 23:06 ` Tom Tromey
2021-09-09 19:00 ` Wei-min Pan
2021-09-11 21:08 ` Tom Tromey
2021-09-13 16:50 ` Weimin Pan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=dd4a83b8-8e7e-09ea-9ca0-921850c1ff44@suse.de \
--to=tdevries@suse.de \
--cc=gdb-patches@sourceware.org \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).