From: Simon Marchi <simark@simark.ca>
To: Tom de Vries <tdevries@suse.de>, gdb-patches@sourceware.org
Subject: Re: [PATCH][gdb/symtab] Add all_comp_units_cu/tu
Date: Sat, 17 Sep 2022 05:59:40 -0400 [thread overview]
Message-ID: <8038e1cd-b065-4cfd-d5d9-af6d957c92fc@simark.ca> (raw)
In-Reply-To: <20220916124250.GA19747@delia>
On 9/16/22 08:42, Tom de Vries via Gdb-patches wrote:
> Hi,
>
> Add all_comp_units_cu and all_comp_units_tu arrayviews on all_comp_units,
> which allows us to:
> - easily get the number of CUs or TUs in all_comp_units, and
> - easily access the nth CU or TU.
I think it's a good idea, but I would suggest reworking the naming a
bit. I find it unclear to comp_units_cu and comp_units_tu, given that
"cu" means comp_units. I would suggest renaming all_comp_units to
all_units (since it contains units of different kinds), and then you can
have all_comp_units and all_type_units for the array views.
Simon
next prev parent reply other threads:[~2022-09-17 9:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-16 12:42 Tom de Vries
2022-09-17 9:59 ` Simon Marchi [this message]
2022-09-18 8:13 ` Tom de Vries
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8038e1cd-b065-4cfd-d5d9-af6d957c92fc@simark.ca \
--to=simark@simark.ca \
--cc=gdb-patches@sourceware.org \
--cc=tdevries@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).