Re: [PATCH][gdb/symtab] Add all_comp_units_cu/tu

[Tom de Vries <tdevries@suse.de>]

On 9/17/22 11:59, Simon Marchi wrote:
> On 9/16/22 08:42, Tom de Vries via Gdb-patches wrote:
>> Hi,
>>
>> Add all_comp_units_cu and all_comp_units_tu arrayviews on all_comp_units,
>> which allows us to:
>> - easily get the number of CUs or TUs in all_comp_units, and
>> - easily access the nth CU or TU.
> 
> I think it's a good idea, but I would suggest reworking the naming a
> bit.  I find it unclear to comp_units_cu and comp_units_tu, given that
> "cu" means comp_units.  I would suggest renaming all_comp_units to
> all_units (since it contains units of different kinds), and then you can
> have all_comp_units and all_type_units for the array views.

I've done that now.

I initially had two patches that I merged and tested, but I reverted 
back to two patches because I think it'll be easier to review.

Sumitted here:
- https://sourceware.org/pipermail/gdb-patches/2022-September/191908.html
- https://sourceware.org/pipermail/gdb-patches/2022-September/191907.html

Thanks,
- Tom