From: Ulrich Weigand <Ulrich.Weigand@de.ibm.com>
To: "gdb-patches@sourceware.org" <gdb-patches@sourceware.org>,
"tom@tromey.com" <tom@tromey.com>
Cc: Sangamesh Mallayya <sangamesh.swamy@in.ibm.com>,
Aditya Kamath1 <Aditya.Kamath1@ibm.com>,
"simon.marchi@efficios.com" <simon.marchi@efficios.com>
Subject: Re: [PATCH] Modify align-c/align-c++ test case for AIX
Date: Tue, 21 Mar 2023 14:26:01 +0000 [thread overview]
Message-ID: <82c24017291c399d58fc87d7ae7fc1b17c665295.camel@de.ibm.com> (raw)
In-Reply-To: <877cvagpeh.fsf@tromey.com>
Tom Tromey <tom@tromey.com> wrote:
>Ulrich> If the -bnogc flag is always necessary with the AIX linker, this
>Ulrich> should be handled automatically by the test instead of via site.exp.
>
>Ulrich> I'm assuming this is only needed with test files that use global
>Ulrich> variables unused in the source code, but used by the debugger.
>Ulrich> I think it would be best to explicitly add the flag to those tests
>Ulrich> where it is needed.
>
>I think there's also cases in the test suite where we've added uses of
>variables to ensure they aren't optimized away. With a comment
>somewhere explaining why, I'm also ok with that. It seems less
>intrusive maybe than adding ldflags to a lot of tests.
Well, that was Aditya's original proposal, I guess ... I'd be fine
with that as well - whatever is easier.
I think doing a global run with -Wl,-bnogc would still be interesting,
simply to get a list of all the tests that would need changing.
Bye,
Ulrich
next prev parent reply other threads:[~2023-03-21 14:26 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-10 8:57 Aditya Kamath1
2023-03-10 14:46 ` Tom Tromey
2023-03-13 13:04 ` Aditya Kamath1
2023-03-13 14:10 ` Ulrich Weigand
2023-03-15 11:52 ` Aditya Kamath1
2023-03-15 12:45 ` Tom Tromey
2023-03-16 7:01 ` Aditya Kamath1
2023-03-17 17:06 ` Ulrich Weigand
2023-03-17 22:03 ` Tom Tromey
2023-03-21 7:01 ` Aditya Kamath1
2023-03-21 7:41 ` Ulrich Weigand
2023-03-21 11:05 ` Pedro Alves
2023-03-21 14:17 ` Tom Tromey
2023-03-21 14:26 ` Ulrich Weigand [this message]
2023-03-29 11:28 ` Aditya Kamath1
2023-03-29 13:36 ` Pedro Alves
2023-03-31 12:29 ` Aditya Kamath1
2023-04-04 13:24 ` Aditya Kamath1
2023-04-05 16:33 ` Pedro Alves
2023-04-06 13:15 ` Aditya Kamath1
2023-04-06 16:18 ` Pedro Alves
-- strict thread matches above, loose matches on Subject: below --
2023-03-10 8:56 Aditya Kamath1
2023-03-10 10:08 ` Aditya Kamath1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82c24017291c399d58fc87d7ae7fc1b17c665295.camel@de.ibm.com \
--to=ulrich.weigand@de.ibm.com \
--cc=Aditya.Kamath1@ibm.com \
--cc=gdb-patches@sourceware.org \
--cc=sangamesh.swamy@in.ibm.com \
--cc=simon.marchi@efficios.com \
--cc=tom@tromey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).