[PATCH] Modify align-c/align-c++ test case for AIX

[Aditya Kamath1 <Aditya.Kamath1@ibm.com>]

[-- Attachment #1.1: Type: text/plain, Size: 974 bytes --]

Hi all,

Please find attached the patch. {See:- 0001-Modify-align-c-align-c-test-case-for-AIX.patch}

In AIX, we have observed around 1500 failures in align-c/align-c++ testcase. The reason being this testcase shows the alignment outputs of global variables that are unused in the main (). In AIX we need to use atleast one global variable to access the same. This patch is a fix to the same. This issue is like this link pasted in the next line which we fixed before. https://sourceware.org/git/?p=binutils-gdb.git;a=commit;h=60204874f5a987b164f7f194d3f96729847fe329

Kindly let me know if this is okay.

Test case command:- gmake RUNTESTFLAGS="gdb.base/align-c.exp" check
                                       gmake RUNTESTFLAGS="gdb.base/align-c++.exp" check
Test case passes before the patch :- 0 for align-c++ and align-c
Test case passes after this patch:- 1134 for align-c++ and 406 for align-c.

Have a nice day ahead.

Thanks and regards,
Aditya.

[-- Attachment #2: 0001-Modify-align-c-align-c-test-case-for-AIX.patch --]
[-- Type: application/octet-stream, Size: 1004 bytes --]

From 5daed42ecd34d0019f3a2e4828a5b014ee865452 Mon Sep 17 00:00:00 2001
From: Aditya Vidyadhar Kamath <Aditya.Kamath1@ibm.com>
Date: Fri, 10 Mar 2023 01:22:14 -0600
Subject: [PATCH] Modify align-c/align-c++ test case for AIX

On AIX, the debugger cannot access global variables before they
they are used in any function. Hence we add this small change so
that we can test the same in AIX.
---
 gdb/testsuite/gdb.base/align.exp.tcl | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/gdb/testsuite/gdb.base/align.exp.tcl b/gdb/testsuite/gdb.base/align.exp.tcl
index 6a75a14d887..f18243080ce 100644
--- a/gdb/testsuite/gdb.base/align.exp.tcl
+++ b/gdb/testsuite/gdb.base/align.exp.tcl
@@ -109,6 +109,11 @@ proc prepare_test_source_file { lang } {
     # Epilogue.
     puts $outfile {
 	int main() {
+	    #ifdef _AIX
+	    /* On AIX, the debugger cannot access global variables before they
+		they are used in the functions.  */
+		a_char_x_char++;
+	    #endif
 	    return 0;
 	}
     }
-- 
2.38.3