From: Simon Marchi <simark@simark.ca>
To: Bruno Larsen <blarsen@redhat.com>, gdb-patches@sourceware.org
Cc: simon.marchi@efficios.com
Subject: Re: [PING*3][PATCH v3 0/2] [gdb] untie and validate inheritance location
Date: Mon, 8 Nov 2021 16:16:37 -0500 [thread overview]
Message-ID: <831920d0-ba0f-12a7-4082-e7dce432793c@simark.ca> (raw)
In-Reply-To: <cb1cf834-3964-4417-b851-86a978a9f03b@redhat.com>
On 2021-11-08 1:33 p.m., Bruno Larsen via Gdb-patches wrote:
> Ping
Hi Bruno,
When fixing a bug, I like to add infrastructure and checks in place that
would have caught that bug, hoping that it will help catch more bugs of
the same class. While reviewing your patch, I went into the rabbit hole
of making the value_contents & co functions return an array_view, and
then make it possible to copy from an array view to another, verifying
that the array views have the same size. That would have caught the bug
in patch 2 I think.
Here's my series: https://sourceware.org/pipermail/gdb-patches/2021-November/183251.html
I hope for it to be merged soon, and then when we rebase your series on
top of it, the assertion in value_contents_copy_raw would no longer be
needed, since it would implicitly be done by the array_view copy.
Simon
prev parent reply other threads:[~2021-11-08 21:16 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-30 19:26 [PATCH " Bruno Larsen
2021-09-30 19:26 ` [PATCH v3 1/2] [gdb] Untied inheritance virtuality and loc kind Bruno Larsen
2021-09-30 19:26 ` [PATCH v3 2/2] [gdb] Add Simple offset validation when calculating baseclass_offset Bruno Larsen
2021-09-30 19:36 ` [PATCH v3 2/2 RESEND] " Bruno Larsen
2021-10-19 19:15 ` [PING][PATCH v3 0/2] [gdb] untie and validate inheritance location Bruno Larsen
2021-11-01 13:17 ` [PING*2][PATCH " Bruno Larsen
2021-11-08 18:33 ` [PING*3][PATCH " Bruno Larsen
2021-11-08 21:16 ` Simon Marchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831920d0-ba0f-12a7-4082-e7dce432793c@simark.ca \
--to=simark@simark.ca \
--cc=blarsen@redhat.com \
--cc=gdb-patches@sourceware.org \
--cc=simon.marchi@efficios.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).