From: Eli Zaretskii <eliz@gnu.org>
To: Aaron Merey <amerey@redhat.com>
Cc: gdb-patches@sourceware.org
Subject: Re: [PATCH] gdb/cli-out.c: clear_current_line shouldn't trigger pagination prompt
Date: Tue, 16 May 2023 05:27:40 +0300 [thread overview]
Message-ID: <831qjh104j.fsf@gnu.org> (raw)
In-Reply-To: <CAJDtP-SZ3-vVOHvXSBim1iuQsEhWB3XiS5OfYphderO-rqw-zw@mail.gmail.com> (message from Aaron Merey on Mon, 15 May 2023 17:32:48 -0400)
> From: Aaron Merey <amerey@redhat.com>
> Date: Mon, 15 May 2023 17:32:48 -0400
> Cc: gdb-patches@sourceware.org
>
> > I'm not sure we should rely on the fact that the final character of
> > the line is never there. clear_current_line is a general-purpose
> > method, so it should do its job regardless.
> >
> > Can't we do something to handle the last character as well? E.g.,
> > could it be possible first to delete one character, so there are
> > really only N-1 characters to fill with blank spaces?
>
> We could rename clear_current_line to something like clear_progress_notify
> to help indicate that this is a special purpose function. We could also
> just disable pagination for the duration of clear_current_line.
I think we should do both, thanks.
next prev parent reply other threads:[~2023-05-16 2:27 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-11 23:22 Aaron Merey
2023-05-12 6:30 ` Eli Zaretskii
2023-05-15 21:32 ` Aaron Merey
2023-05-16 2:27 ` Eli Zaretskii [this message]
2023-05-19 21:38 ` Aaron Merey
2023-05-20 5:48 ` Eli Zaretskii
2023-05-23 15:13 ` Aaron Merey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=831qjh104j.fsf@gnu.org \
--to=eliz@gnu.org \
--cc=amerey@redhat.com \
--cc=gdb-patches@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).