Re: [PATCH v3 2/3] gdb: Add per-remote target variables for memory read and write config

[Eli Zaretskii <eliz@gnu.org>]

> From: Christina Schimpe <christina.schimpe@intel.com>
> Cc: pedro@palves.net,
> 	aburgess@redhat.com,
> 	eliz@gnu.org,
> 	tom@tromey.com,
> 	Christina Schimpe <christina.schimpe@intel.com>
> Date: Fri,  9 Sep 2022 17:37:08 +0200
> 
> diff --git a/gdb/NEWS b/gdb/NEWS
> index d1ed7f015f9..9b22a626868 100644
> --- a/gdb/NEWS
> +++ b/gdb/NEWS
> @@ -11,8 +11,15 @@
>    configure a target's feature packet and to display its configuration,
>    respectively.
>  
> -  The configuration of the packet itself applies to the currently selected
> -  target (if available).  If no target is selected, it applies to future remote
> +  The individual packet sizes can be configured and shown using the commands
> +    ** 'set remote memory-read-packet-size (number of bytes|fixed|limit)'
> +    ** 'set remote memory-write-packet-size (number of bytes|fixed|limit)'
> +    ** 'show remote memory-read-packet-size'
> +    ** 'show remote memory-write-packet-size'.
> +
> +  The configuration of the packet itself, as well as the size of a memory-read
> +  or memory-write packet applies to the currently selected target (if
> +  available).  If no target is selected, it applies to future remote
>    connections.  Similarly, the show commands print the configuration of the
>    currently selected target.  If no remote target is selected, the default
>    configuration for future connections is shown.

This part is OK.

> --- a/gdb/doc/gdb.texinfo
> +++ b/gdb/doc/gdb.texinfo
> @@ -23959,6 +23959,20 @@ future connections is shown.  The available settings are:
>  
>  @end multitable
>  
> +@cindex configuration of the remote packet size

A better index entry would start with "remote packet size", because
users are more likely to have that in mind than the general-purpose
word like "configuration".

For even better results, add one more index entry sat=ying

  @cindex packet size, remote, configuring

> +The number of bytes per memory-read or memory-write packet for a remote target
> +can be configured using the commands @code{set remote memory-read-packet-size}
> +and @code{set remote memory-write-packet-size}.  If set to @samp{0} (zero) the

The commands should be in @w{..}, to make sure they aren't split
between two lines, which makes them harder to read.

Thanks.